rest: Improve tests and documention of /headers and /block #15177

pull promag wants to merge 3 commits into bitcoin:master from promag:2019-01-restheadersdoc changing 2 files +12 −0

promag commented at 11:46 AM on January 16, 2019: member

Follow up of #15107.
doc: Explain empty result of /rest/headers be625f7c55
fanquake added the label Docs on Jan 16, 2019
laanwj commented at 1:31 PM on January 16, 2019: member

utACK
doc: /rest/block responds with 404 if block does not exist 0825b86b28
qa: Improve tests of /rest/headers and /rest/block 7cf994d5cf
promag force-pushed on Jan 16, 2019
promag renamed this:
~~doc: Explain empty result of /rest/headers~~
Improve tests and documention of /rest/headers and /rest/block
on Jan 16, 2019
promag commented at 2:59 PM on January 16, 2019: member

Now with /rest/block documentation and test improvement.
promag renamed this:
~~Improve tests and documention of /rest/headers and /rest/block~~
rest: Improve tests and documention of /headers and /block
on Jan 16, 2019
hebasto commented at 8:41 PM on January 16, 2019: member

utACK 7cf994d5cfd53dcff76ebd0e0007e3477a7570e8 nit: I'm inclined do not use contractions in the docs.

in test/functional/interface_rest.py:211 in 7cf994d5cf

 206 | +        self.test_rest_request('/block/0000000000000000000000000000000000000000000000000000000000000000', status=404, ret_type=RetType.OBJ)
 207 | +
 208 | +        # Check result if block is not in the active chain
 209 | +        self.nodes[0].invalidateblock(bb_hash)
 210 | +        assert_equal(self.test_rest_request('/headers/1/{}'.format(bb_hash)), [])
 211 | +        self.test_rest_request('/block/{}'.format(bb_hash))

Empact commented at 11:55 AM on January 17, 2019:

nit: could be more clear to make explicit what test_rest_request default args you're finding most relevant here

promag commented at 1:01 AM on January 18, 2019:

Maybe explicit status=200?

Empact commented at 11:55 AM on January 17, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15177/commits/7cf994d5cfd53dcff76ebd0e0007e3477a7570e8 could squash
laanwj commented at 4:37 PM on January 21, 2019: member

utACK 7cf994d5cfd53dcff76ebd0e0007e3477a7570e8
laanwj merged this on Jan 21, 2019
laanwj closed this on Jan 21, 2019
laanwj referenced this in commit 72506ed349 on Jan 21, 2019
promag deleted the branch on Jan 21, 2019
jasonbcox referenced this in commit d793890d8d on Nov 10, 2020
PastaPastaPasta referenced this in commit d4cfeb4477 on Jun 26, 2021
PastaPastaPasta referenced this in commit 2887c33c5b on Jun 26, 2021
PastaPastaPasta referenced this in commit 9c9b5efa8e on Jun 27, 2021
PastaPastaPasta referenced this in commit 949f158bc1 on Jun 28, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15107 rest: Return 404 in /rest/headers if block hash does not exists