validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations. #15191

1. 
   practicalswift commented at 8:20 pm on January 17, 2019: contributor

   • Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex().
   • Add missing locking annotation for nLastBlockFile and fCheckForPruning.
   • Add missing locking annotation for nBlockSequenceId which is guarded by cs_nBlockSequenceId.
   • Add missing cs_nBlockSequenceId lock in UnloadBlockIndex().
2. practicalswift renamed this:
   validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning.
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning.
   on Jan 17, 2019
3. practicalswift renamed this:
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning.
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations for nLastBlockFile, fCheckForPruning and nBlockSequenceId.
   on Jan 17, 2019
4. practicalswift force-pushed on Jan 17, 2019
5. practicalswift renamed this:
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations for nLastBlockFile, fCheckForPruning and nBlockSequenceId.
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations.
   on Jan 17, 2019
6. practicalswift renamed this:
   validation: Add missing locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations.
   validation: Add missing cs_{LastBlockFile,nBlockSequenceId} locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotations.
   on Jan 17, 2019
7. fanquake added the label Validation on Jan 17, 2019
8. 
   practicalswift commented at 9:56 pm on February 7, 2019: contributor

   @MarcoFalke Could this one get a release milestone? :-)
9. 
   DrahtBot commented at 4:14 pm on March 15, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #16194 (refactor: share blockmetadata with BlockManager by jamesob)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. DrahtBot added the label Needs rebase on Jun 5, 2019
11. practicalswift force-pushed on Jun 5, 2019
12. 
    practicalswift commented at 11:22 pm on June 5, 2019: contributor

    Rebased!
13. DrahtBot removed the label Needs rebase on Jun 5, 2019
14. 
    practicalswift commented at 5:56 pm on June 26, 2019: contributor

    @MarcoFalke Should this locking PR be closed? Please advice.
15. 
    MarcoFalke commented at 6:15 pm on June 26, 2019: member

    Concept ACK
16. MarcoFalke added this to the milestone 0.19.0 on Jun 26, 2019
17. validation: Add missing cs_LastBlockFile locks in PruneAndFlush() and UnloadBlockIndex(). Add missing locking annotation for nLastBlockFile and fCheckForPruning. d061f5e288
18. validation: Add missing cs_nBlockSequenceId lock in UnloadBlockIndex(). Add missing locking annotation for nBlockSequenceId. 575720c2cb
19. practicalswift force-pushed on Jun 26, 2019
20. 
    DrahtBot commented at 5:18 pm on July 16, 2019: member
21. DrahtBot added the label Needs rebase on Jul 16, 2019
22. practicalswift closed this on Aug 10, 2019

    ---

23. laanwj removed the label Needs rebase on Oct 24, 2019
24. 
    dongcarl commented at 8:47 pm on December 24, 2020: member

    Wondering if this change is still necessary and conceptually sound?
25. 
    practicalswift commented at 7:36 pm on December 27, 2020: contributor

    @dongcarl

    I haven’t looked at this since closing, but IIRC I closed it due to lack of progress only (only one Concept ACK over seven months 😢 ).

    Feel free to pick it up: I’d be glad to review :)

26. practicalswift deleted the branch on Apr 10, 2021
27. DrahtBot locked this on Aug 18, 2022

Contributors
practicalswift DrahtBot MarcoFalke dongcarl

Labels
Validation

Milestone
0.19.0