- Improve tests by checking for expected return values
- Warn on discarded return values (
[[noreturn]]) for important functions - Explicitly cast to void to document where we are intentionally discarding return values
tests: Check for expected return values when calling functions returning a success code #15214
pull practicalswift wants to merge 3 commits into bitcoin:master from practicalswift:check-return-values-in-tests changing 10 files +47 −32-
practicalswift commented at 1:21 PM on January 20, 2019: contributor
- fanquake added the label Refactoring on Jan 20, 2019
- fanquake added the label Tests on Jan 20, 2019
- practicalswift renamed this:
Improve tests by checking for expected return values
tests: Check for expected return values when calling functions returning a success code
on Jan 20, 2019 - practicalswift force-pushed on Jan 20, 2019
- practicalswift force-pushed on Jan 20, 2019
-
DrahtBot commented at 2:52 PM on January 20, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15452 (Replace CScriptID and CKeyID in CTxDestination with dedicated types by instagibbs)
- #13062 (Make script interpreter independent from storage type CScript by sipa)
- #10729 (Wrap EvalScript in a ScriptExecution class by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- practicalswift force-pushed on Jan 20, 2019
- practicalswift force-pushed on Jan 20, 2019
- practicalswift force-pushed on Jan 20, 2019
- DrahtBot added the label Needs rebase on Feb 14, 2019
-
Improve tests by checking for expected return values 6b9ef98d94
-
Warn on discarded return values ([[noreturn]]) 64cb79d742
-
Explicitly cast to void to document where we are intentionally discarding return values cfdc9a7326
- practicalswift force-pushed on Feb 15, 2019
- DrahtBot removed the label Needs rebase on Feb 15, 2019
- practicalswift closed this on Feb 28, 2019
- practicalswift deleted the branch on Apr 10, 2021
- DrahtBot locked this on Aug 18, 2022
Contributors
Labels