Drop defunct Windows compat fixes #15231

Empact commented at 11:01 PM on January 22, 2019: member

"The AI_ADDRCONFIG flag is defined on the Windows SDK for Windows Vista and later. The AI_ADDRCONFIG flag is supported on Windows Vista and later." https://docs.microsoft.com/en-us/windows/desktop/api/ws2tcpip/nf-ws2tcpip-getaddrinfo

However, the version of MinGW we use on Travis is not current and does not carry the relevant definition, as such I defined it in compat. https://github.com/wine-mirror/wine/blob/master/include/ws2tcpip.h

Testing confirms that the PROTECTION_LEVEL_UNRESTRICTED and IPV6_PROTECTION_LEVEL are now supported by the version of windows that we test against, so can be removed. https://travis-ci.org/bitcoin/bitcoin/jobs/483255439

fanquake added the label P2P on Jan 22, 2019

laanwj commented at 11:04 PM on January 22, 2019: member

Nice utACK 8f68b80dd6f30e0a975f44bb5001c033ce381642

Empact commented at 1:00 AM on January 23, 2019: member

Looks like I’m missing the necessary require. Will look tonight.

Empact force-pushed on Jan 23, 2019

ken2812221 commented at 8:30 AM on January 23, 2019: contributor

I think that this would require to define _WIN32_WINNT=0x0601 (Windows 7) at first. Otherwise the mingw would consider the minimum OS version should be supported is Windows XP SP1 ( _WIN32_WINNT=0x0502) by default. ref #14922

Empact force-pushed on Jan 23, 2019

Empact renamed this:
~~Drop defunct Windows LookupIntern exception~~
Drop defunct Windows compat fixes
on Jan 23, 2019

Empact commented at 9:30 AM on January 23, 2019: member

@ken2812221 Seems this is working despite the version not being set, thanks to the shim in compat.h, but I suspect we can remove that if we set the _WIN32_WINNT version. We should be able to detect that situation when it occurs thanks to the FAIL_ON_EXTRANEOUS_COMPAT case I added here.

Empact force-pushed on Jan 23, 2019

Drop defunct Windows compat fixes

"The AI_ADDRCONFIG flag is defined on the Windows SDK for Windows Vista
and later. The AI_ADDRCONFIG flag is supported on Windows Vista and
later."
https://docs.microsoft.com/en-us/windows/desktop/api/ws2tcpip/nf-ws2tcpip-getaddrinfo

However, the version of MinGW we use on Travis is not current and does
not carry the relevant definition, as such I defined it in compat.
https://github.com/wine-mirror/wine/blob/master/include/ws2tcpip.h

Testing confirms that the PROTECTION_LEVEL_UNRESTRICTED and
IPV6_PROTECTION_LEVEL are now supported by the version of windows that
we test against, so can be removed.
https://travis-ci.org/bitcoin/bitcoin/jobs/483255439

6a7a27d683

Empact force-pushed on Jan 23, 2019

DrahtBot commented at 3:26 PM on January 23, 2019: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#14922 (windows: Set _WIN32_WINNT to 0x0601 (Windows 7) by ken2812221)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

laanwj commented at 2:31 PM on January 24, 2019: member

I think that this would require to define _WIN32_WINNT=0x0601 (Windows 7)

In that case it might be better to merge this into #14922

Empact commented at 12:06 AM on January 25, 2019: member

Sounds good, the relevant changes are in: https://github.com/Empact/bitcoin/commit/d0522ec94ebbaa564f5f6b31236d4df032664411 if @ken2812221 wants to pick them up.

Empact commented at 4:26 AM on January 25, 2019: member

Closing in favor of #14922

Empact closed this on Jan 25, 2019

Empact deleted the branch on Jan 25, 2019

DrahtBot locked this on Dec 16, 2021