scripts and tools: Move non-linux build source tarballs to "bitcoin-binaries/version" directory #15239

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:20190123-gitian-source-tarballs changing 1 files +2 −2

hebasto commented at 8:54 PM on January 23, 2019: member

Currently, if a user makes a non-linux (--os=w, --os=m or --os=wm) gitian building with the gitian-build.py script, source tarballs are not moved to the bitcoin-binaries/${VERSION} directory.

This PR fixes this bug.

~~In addition, the src subdirectory in the gitian-builder/build/out directory is no longer used as unnecessary.~~
Move non-linux source tarball to bitcoin-binaries 5c04814b2d
fanquake added the label Build system on Jan 23, 2019
laanwj requested review from ken2812221 on Jan 24, 2019
ken2812221 commented at 11:50 PM on January 24, 2019: contributor

Personally I would prefer to keep gitian build yml as it and copy it from src directory every build stage to keep compatibility with previous copied gitian-build.sh or gitian-build.py script.
hebasto force-pushed on Jan 25, 2019
hebasto commented at 8:31 AM on January 25, 2019: member

@ken2812221 Thank you for your review. Your comment has been addressed and the second commit has been dropped.
ken2812221 approved
ken2812221 commented at 8:54 AM on January 25, 2019: contributor

utACK 5c04814b2de179fd03ca18c19049f035a2454f81
hebasto commented at 6:02 PM on May 9, 2019: member

@fanquake Would you mind reviewing this PR?
fanquake commented at 1:43 AM on May 10, 2019: member

utACK 5c04814
MarcoFalke merged this on May 10, 2019
MarcoFalke closed this on May 10, 2019
MarcoFalke referenced this in commit 87dbf89271 on May 10, 2019
hebasto deleted the branch on May 10, 2019
sidhujag referenced this in commit 78e93d11e0 on May 10, 2019
UdjinM6 referenced this in commit cf1021e480 on Sep 1, 2021
UdjinM6 referenced this in commit 94c54830f6 on Sep 2, 2021
UdjinM6 referenced this in commit 3fdf06d197 on Sep 2, 2021
UdjinM6 referenced this in commit 1e781c016f on Sep 2, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels