The added configuration would have found #15233 before it happened. It may be worth to add other machine configs, but so far, only macs have croaked, so not going there yet.
travis: add --enable-debug macos build #15241
pull kallewoof wants to merge 1 commits into bitcoin:master from kallewoof:travis-enable-debug-macos changing 1 files +11 −0-
kallewoof commented at 7:48 AM on January 24, 2019: member
- kallewoof force-pushed on Jan 24, 2019
- fanquake added the label Tests on Jan 24, 2019
- kallewoof force-pushed on Jan 24, 2019
- kallewoof force-pushed on Jan 24, 2019
-
DrahtBot commented at 8:42 AM on January 24, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15112 (build: Optionally enable -Wzero-as-null-pointer-constant by Empact)
- #14920 (Build: enable -Wdocumentation via isystem by Empact)
- #13728 (WIP: Scripts and tools: Run the CI lint stage on mac by Empact)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
Sjors commented at 3:56 PM on January 24, 2019: member
Are you sure this works? Wouldn't this try to run a macOS cross-compiled binary in a Linux environment? The other macOS machine doesn't run unit tests at all:
RUN_UNIT_TESTS=false.Maybe we should try out the native macOS Travis environment? https://docs.travis-ci.com/user/reference/osx/ (
cc @MarcoFalke
-
promag commented at 6:12 PM on January 24, 2019: member
Not sure if the cross-compile binary has the #15227 problem.
I think @Sjors's suggestion is good, more info in https://docs.travis-ci.com/user/multi-os/.
-
MarcoFalke commented at 10:31 PM on January 24, 2019: member
How is this a bug only on macos? I'd prefer to run the tests in bionic with clang (and whatever else macos uses)
-
kallewoof commented at 2:07 AM on January 25, 2019: member
I will do more tests to see if this solves the problem with the patch cherry-picked. I assumed it would, but you're right, maybe not. @MarcoFalke I think it only appeared for mac users.
-
sipa commented at 3:42 AM on January 25, 2019: member
This doesn't work, we can't run cross-compiled OSX binaries in the Linux build environment.
-
travis: add --enable-debug macos build f64f897cad
- kallewoof force-pushed on Jan 25, 2019
-
- kallewoof closed this on Jan 25, 2019
- kallewoof deleted the branch on Jan 25, 2019
- DrahtBot locked this on Dec 16, 2021
Labels