remove deprecated mentions of signrawtransaction from fundraw help #15245

1. 
   instagibbs commented at 9:29 PM on January 24, 2019: member

   RPC call has been removed as of 0.17.99.

2. fanquake added the label RPC/REST/ZMQ on Jan 24, 2019
3. 
   fanquake commented at 5:27 AM on January 25, 2019: member

   Concept ACK. There are a couple other mentions that can also be updated:

   https://github.com/bitcoin/bitcoin/blob/72bd4ab867e3be0d8410403d9641c08288d343e3/src/bitcoin-tx.cpp#L65

   https://github.com/bitcoin/bitcoin/blob/72bd4ab867e3be0d8410403d9641c08288d343e3/src/txmempool.h#L749

4. 
   DrahtBot commented at 3:12 AM on January 26, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

5. instagibbs force-pushed on Jan 29, 2019
6. 
   instagibbs commented at 12:21 PM on January 29, 2019: member

   Removed all mentions of signrawtransaction I could find(that weren't documentation says it was being removed or not to make RPC calls like it)

7. fanquake added the label Needs rebase on Jan 29, 2019
8. MarcoFalke added this to the milestone 0.18.0 on Jan 29, 2019
9. instagibbs force-pushed on Feb 4, 2019
10. 
    instagibbs commented at 2:09 PM on February 4, 2019: member

    rebased

11. fanquake removed the label Needs rebase on Feb 4, 2019
12. 
    fanquake commented at 2:41 PM on February 4, 2019: member

    @instagibbs Looks like you've lost the other signrawtransaction changes.

13. instagibbs force-pushed on Feb 4, 2019
14. instagibbs force-pushed on Feb 4, 2019
15. 
    instagibbs commented at 3:02 PM on February 4, 2019: member

    @fanquake fixed, and noticed I was typing "withprivkey" sometimes, so fixed those as well.

16. in src/wallet/rpcwallet.cpp:3083 in e79bd1efb5 outdated

    3077 | @@ -3077,9 +3078,9 @@ static UniValue fundrawtransaction(const JSONRPCRequest& request)
    3078 |                              "\nAdd sufficient unsigned inputs to meet the output value\n"
    3079 |                              + HelpExampleCli("fundrawtransaction", "\"rawtransactionhex\"") +
    3080 |                              "\nSign the transaction\n"
    3081 | -                            + HelpExampleCli("signrawtransaction", "\"fundedtransactionhex\"") +
    3082 | +                            + HelpExampleCli("signrawtransactionwithwallet", "\"fundedtransactionhex\"") +
    3083 |                              "\nSend the transaction\n"
    3084 | -                            + HelpExampleCli("sendrawtransaction", "\"signedtransactionhex\"")
    3085 | +                            + HelpExampleCli("sendrawtransactionwithwallet", "\"signedtransactionhex\"")
    

    ---

    ---

    

    kristapsk commented at 3:19 PM on February 4, 2019:

    It's still sendrawtransaction, not sendrawtransactionwithwallet.

    ---

    

    instagibbs commented at 3:29 PM on February 4, 2019:

    that's an error I introduced, oops

17. kristapsk changes_requested
18. remove deprecated mentions of signrawtransaction from fundraw help 851380ce17
19. instagibbs force-pushed on Feb 4, 2019
20. kristapsk approved
21. 
    kristapsk commented at 3:40 PM on February 4, 2019: contributor

    utACK 851380ce177bccf0d608fa8017a383f2ac273dc1

22. 
    fanquake commented at 11:50 PM on February 4, 2019: member

    utACK 851380c

23. MarcoFalke merged this on Feb 5, 2019
24. MarcoFalke closed this on Feb 5, 2019

    ---

25. MarcoFalke referenced this in commit fc21bb4e35 on Feb 5, 2019
26. jasonbcox referenced this in commit b6e5fb3271 on Jul 8, 2020
27. vijaydasmp referenced this in commit 3a4fa6d209 on Sep 5, 2021
28. vijaydasmp referenced this in commit 5a627762c1 on Sep 6, 2021
29. MarcoFalke locked this on Dec 16, 2021

Contributors

instagibbsfanquakeDrahtBotkristapsk

Milestone
0.18.0