This script compared paths relative to the report directory to test for exclusion,
meaning the EXCLUDE_DIRS directory exclusions did not work properly, as
they were relative to the project root.
Fix this by creating absolute paths through the combination of: 'git ls-files --full-name' and 'git rev-parse --show-toplevel'
Once this is done, we can stop testing for the names that would otherwise appear when exclusion of leveldb, secp256k1, etc., did not work as intended.
This script compared paths relative to the report directory to test for exclusion,
meaning the directory exclusions did not work properly, as they were relative to
the project root.
Fix this by creating absolute paths through the combination of:
'git ls-files --full-name' and 'git rev-parse --show-toplevel'
Now that leveldb, secp256k1, etc. are reliably excluded, these
names will not show up in the searched files.
Before:
$ contrib/devtools/copyright_header.py report src
-------------------------------------------------------------------------------
720 files examined according to INCLUDE and EXCLUDE fnmatch rules
-------------------------------------------------------------------------------
26 with zero copyrights
549 with one copyright
143 with two copyrights
2 with three copyrights
0 with four or more copyrights
-------------------------------------------------------------------------------
Copyrights with dominant style:
e.g. "Copyright (c)" and "<year>" or "<startYear>-<endYear>":
135 with 'Satoshi Nakamoto\n'
492 with 'The Bitcoin Core developers\n'
127 with 'The LevelDB Authors\. All rights reserved\.\n'
1 with 'BitPay Inc\.\n'
5 with 'Pieter Wuille\n'
22 with 'Pieter Wuille +\*\n'
2 with 'Pieter Wuille, Andrew Poelstra +\*\n'
6 with 'Andrew Poelstra +\*\n'
1 with 'Diederik Huys, Pieter Wuille +\*\n'
1 with 'Intel Corporation'
6 with 'The Zcash developers'
1 with 'Jeremy Rubin'
-------------------------------------------------------------------------------
Copyrights with year list style:
e.g. "Copyright (c)" and "<year1>, <year2>, ...":
25 with 'Pieter Wuille +\*\n'
2 with 'Pieter Wuille, Gregory Maxwell +\*\n'
1 with 'Thomas Daede, Cory Fields +\*\n'
-------------------------------------------------------------------------------
Copyrights with no "(c)" style:
e.g. "Copyright" and "<year>" or "<startYear>-<endYear>":
3 with 'Bitcoin Core Developers\n'
3 with 'The LevelDB Authors\. All rights reserved\.\n'
7 with 'BitPay Inc\.\n'
1 with 'Wladimir J. van der Laan\n'
-------------------------------------------------------------------------------
0 with unexpected copyright holder names
-------------------------------------------------------------------------------
After:
$ contrib/devtools/copyright_header.py report src
-------------------------------------------------------------------------------
507 files examined according to INCLUDE and EXCLUDE fnmatch rules
-------------------------------------------------------------------------------
11 with zero copyrights
355 with one copyright
139 with two copyrights
2 with three copyrights
0 with four or more copyrights
-------------------------------------------------------------------------------
Copyrights with dominant style:
e.g. "Copyright (c)" and "<year>" or "<startYear>-<endYear>":
135 with 'Satoshi Nakamoto\n'
491 with 'The Bitcoin Core developers\n'
5 with 'Pieter Wuille\n'
1 with 'Intel Corporation'
6 with 'The Zcash developers'
1 with 'Jeremy Rubin'
-------------------------------------------------------------------------------
Copyrights with year list style:
e.g. "Copyright (c)" and "<year1>, <year2>, ...":
-------------------------------------------------------------------------------
Copyrights with no "(c)" style:
e.g. "Copyright" and "<year>" or "<startYear>-<endYear>":
-------------------------------------------------------------------------------
0 with unexpected copyright holder names
-------------------------------------------------------------------------------
$ contrib/devtools/copyright_header.py report . is unchanged.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.