We only enter the if blocks if solved is true.
The && inside seems redundant
remove redundant 'solved' from ProduceSignature #15274
pull fivepiece wants to merge 1 commits into bitcoin:master from fivepiece:sign_redundant_solved changing 1 files +3 −3-
fivepiece commented at 10:00 PM on January 27, 2019: contributor
-
5579bb1c5f
remove redundant 'solved' from ProduceSignature
We only enter the 'if' blocks if 'solved' is true. The '&&' inside is redundant
- fanquake added the label Refactoring on Jan 27, 2019
-
-
Empact commented at 3:54 PM on January 28, 2019: member
It's slightly protective in that it guards against the unintentional introduction of a new case that overwrites a
falsesolved.assertcould be more helpful if we want to continue to guard against that though. -
laanwj commented at 12:12 PM on January 31, 2019: member
No harm keeping them though.
It's slightly protective in that it guards against the unintentional introduction of a new case that overwrites a false solved
Meh. Tend towards NACK, I see no strong need to change this code, sorry.
- laanwj closed this on Feb 4, 2019
-
jonasschnelli commented at 7:03 PM on February 4, 2019: contributor
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels