The bitcoin-wallet.exe would have to link with libsecp256k1 after we build libsecp256k1 in project.
msvc: Fix silent merge conflict between #13926 and #14372 #15325
pull ken2812221 wants to merge 1 commits into bitcoin:master from ken2812221:msvc-merge-conflict changing 1 files +3 −0-
ken2812221 commented at 11:12 PM on February 1, 2019: contributor
-
msvc: Fix silent merge conflict between #13926 and #14372 bef8fdd6e2
- MarcoFalke added this to the milestone 0.18.0 on Feb 1, 2019
-
MarcoFalke commented at 11:17 PM on February 1, 2019: member
cc @sipsorcery
- MarcoFalke added the label Windows on Feb 1, 2019
-
MarcoFalke commented at 4:41 AM on February 3, 2019: member
tool_wallet seems to pass already: https://ci.appveyor.com/project/DrahtBot/bitcoin/builds/22082489#L129
-
NicolasDorier commented at 5:50 AM on February 3, 2019: contributor
tACK
-
ken2812221 commented at 6:45 AM on February 3, 2019: contributor
@MarcoFalke I think that MSVC is trying to link with vcpkg's secp256k1 library that is in the cache.
error if we clear the cache: https://ci.appveyor.com/project/ken2812221/bitcoin/builds/22067759
-
sipsorcery commented at 10:34 AM on February 3, 2019: member
tACK bef8fdd6e2293efdaf05f804a8cff69380c8665e.
- MarcoFalke referenced this in commit 6a5feb7d82 on Feb 4, 2019
- MarcoFalke merged this on Feb 4, 2019
- MarcoFalke closed this on Feb 4, 2019
- ken2812221 deleted the branch on Feb 4, 2019
- MarcoFalke referenced this in commit e3b1c7a9d6 on Feb 14, 2019
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels
Milestone
0.18.0