[doc] netaddress: Make IPv4 loopback comment more descriptive #15343

pull dongcarl wants to merge 2 commits into bitcoin:master from dongcarl:2019-02-islocal-clarify changing 1 files +8 −8

dongcarl commented at 4:49 PM on February 4, 2019: member

This also makes the comment match the IPv6 comment just below this hunk.
netaddress: Fix indentation in IsLocal 6180b5f32b
netaddress: Make IPv4 loopback comment more descriptive 87aa0b48af
in src/netaddress.cpp:185 in b991c80c0c outdated
```
 181 | @@ -182,7 +182,7 @@ bool CNetAddr::IsTor() const
 182 |  
 183 |  bool CNetAddr::IsLocal() const
 184 |  {
 185 | -    // IPv4 loopback
 186 | +   // IPv4 loopback (127.0.0.0/8 or 0.0.0.0/8)
```
laanwj commented at 6:22 PM on February 4, 2019:

Indentation should always be 4 spaces

MarcoFalke commented at 6:48 PM on February 4, 2019:

Don't forget to install clang-format and run the https://github.com/bitcoin/bitcoin/tree/master/contrib/devtools#clang-format-diffpy script to preempt whitespace nitpicking.
dongcarl force-pushed on Feb 4, 2019
dongcarl commented at 6:52 PM on February 4, 2019: member

Fixed!
MarcoFalke renamed this:
~~netaddress: Make IPv4 loopback comment more descriptive~~
[doc] netaddress: Make IPv4 loopback comment more descriptive
on Feb 4, 2019
MarcoFalke added the label Docs on Feb 4, 2019
fanquake commented at 3:22 PM on February 5, 2019: member

utACK 87aa0b4

Theerror C2065: 'g_logger': undeclared identifier Appveyor failure has been fixed in #15347.
kristapsk approved
kristapsk commented at 3:32 PM on February 5, 2019: contributor

utACK 6180b5f32bbcd7ef18db772290954161806e609e
laanwj merged this on Feb 6, 2019
laanwj closed this on Feb 6, 2019
laanwj referenced this in commit 72d34c0edc on Feb 6, 2019
deadalnix referenced this in commit c1e1a85bd3 on Jun 9, 2020
ftrader referenced this in commit ace2fdc6e5 on Aug 17, 2020
Munkybooty referenced this in commit f6be8a8501 on Aug 24, 2021
Munkybooty referenced this in commit 7ce7867dd9 on Sep 1, 2021
Munkybooty referenced this in commit 067318234d on Sep 5, 2021
Munkybooty referenced this in commit 0bedd3567e on Sep 7, 2021
Munkybooty referenced this in commit e389f8c4cb on Sep 7, 2021
Munkybooty referenced this in commit 257290b845 on Sep 9, 2021
Munkybooty referenced this in commit 7de99cb5ad on Sep 10, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels