docs: Minor textual improvements in translation_strings_policy.md #15353

pull merland wants to merge 1 commits into bitcoin:master from merland:patch-3 changing 1 files +8 −8

merland commented at 1:55 PM on February 6, 2019: contributor

Found a few places where the reading flow was interrupted by minor grammar and punctuation issues.
fanquake added the label Docs on Feb 6, 2019

in doc/translation_strings_policy.md:45 in 326760eb21 outdated

  44 |  ### Do not translate internal errors
  45 |  
  46 | -Do not translate internal errors, or log messages, or messages that appear on the RPC interface. If an error is to be shown to the user,
  47 | -use a translatable generic message, then log the detailed message to the log. E.g. "A fatal internal error occurred, see debug.log for details".
  48 | +Do not translate internal errors, log messages, or messages that appear on the RPC interface. If an error is to be shown to the user,
  49 | +use a translatable generic message, then log the detailed message to the log. E.g "A fatal internal error occurred, see debug.log for details".

hebasto commented at 7:43 PM on February 6, 2019:

"E.g." should be followed by a comma (as we use American English for docs). Ref: https://en.wikipedia.org/wiki/List_of_Latin_phrases_(E)#e.g.

merland commented at 8:48 AM on February 7, 2019:

good catch, will update!

in doc/translation_strings_policy.md:85 in 326760eb21 outdated

  81 | @@ -82,7 +82,7 @@ This adds `<numerusform>`s to the respective `.ts` file, which can be translated
  82 |          </translation>
  83 |      </message>
  84 |  
  85 | -Where it is possible try to avoid embedding numbers into the flow of the string at all. e.g.
  86 | +Where possible, try to avoid embedding numbers into the flow of the string at all. e.g.

hebasto commented at 7:44 PM on February 6, 2019:

Same here. Also the first letter should be capitalized after a full stop, right?

merland commented at 8:48 AM on February 7, 2019:

good catch, will update!

hebasto changes_requested
fanquake commented at 7:15 AM on February 8, 2019: member

Please squash your changes, and remove any @ mentions from commit messages.
A few textual improvements a94e470921
merland force-pushed on Feb 8, 2019
merland commented at 8:49 AM on February 8, 2019: contributor

Squashed and fixed commit message.
fanquake commented at 2:02 PM on February 11, 2019: member

utACK a94e470

Please keep your commit messages more specific in future. i.e docs: textual improvements in translation_strings_policy.md.
MarcoFalke merged this on Feb 11, 2019
MarcoFalke closed this on Feb 11, 2019
MarcoFalke referenced this in commit 1bc149d05b on Feb 11, 2019
PastaPastaPasta referenced this in commit ebb04874c4 on Jun 27, 2021
PastaPastaPasta referenced this in commit 61df4e8870 on Jun 28, 2021
PastaPastaPasta referenced this in commit 45371962b1 on Jun 28, 2021
PastaPastaPasta referenced this in commit 80f54e3067 on Jun 29, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels