This adds lock annotations for mapAddressBook and also moves one lock from inside GetDestValues to the caller to be in line with the other methods (eraseDestData, addDestData, ...)
wallet: Add lock annotation for mapAddressBook #15365
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:Mf1902-LockAnnotmapAddressBook changing 7 files +13 −13-
MarcoFalke commented at 7:39 PM on February 7, 2019: member
- MarcoFalke added the label Refactoring on Feb 7, 2019
- MarcoFalke added the label Wallet on Feb 7, 2019
-
wallet: Add lock annotation for mapAddressBook faa46475d7
- MarcoFalke force-pushed on Feb 7, 2019
-
DrahtBot commented at 8:45 PM on February 7, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #14898 (nextpagepointer flag for listtransactions by hosseinamin)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
practicalswift commented at 9:47 PM on February 7, 2019: contributor
Concept ACK
-
promag commented at 2:49 PM on February 8, 2019: member
utACK faa4647.
-
practicalswift commented at 3:28 PM on February 8, 2019: contributor
utACK faa46475d7d7dc60dcc80be34826cf98fb25dc95
- MarcoFalke referenced this in commit 0206956608 on Feb 8, 2019
- MarcoFalke merged this on Feb 8, 2019
- MarcoFalke closed this on Feb 8, 2019
- MarcoFalke deleted the branch on Feb 8, 2019
- deadalnix referenced this in commit 7c51990b22 on May 28, 2020
- LarryRuane referenced this in commit 0e33fb32db on May 4, 2021
- LarryRuane referenced this in commit 94b4ce0bba on Jun 1, 2021
- Munkybooty referenced this in commit 8f67b2c21d on Aug 27, 2021
- Munkybooty referenced this in commit 9109ea7d96 on Sep 5, 2021
- Munkybooty referenced this in commit ca7c5729fd on Sep 7, 2021
- Munkybooty referenced this in commit 58723deb89 on Sep 7, 2021
- Munkybooty referenced this in commit 2c1426b99a on Sep 9, 2021
- Munkybooty referenced this in commit 4877f3938a on Sep 10, 2021
- Munkybooty referenced this in commit eab6110ab6 on Sep 13, 2021
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels