fuzz: Script validation flags #15399

pull MarcoFalke wants to merge 2 commits into bitcoin:master from MarcoFalke:Mf1902-fuzzSoft changing 3 files +110 −20

MarcoFalke commented at 7:21 PM on February 13, 2019: member

No description provided.
fuzz: Move deserialize tests to test/fuzz/deserialize.cpp fabcfa5f0c
MarcoFalke added the label Tests on Feb 13, 2019
fuzz: Script validation flags fab15ff70e
MarcoFalke force-pushed on Feb 13, 2019
laanwj commented at 7:57 PM on February 13, 2019: member

Code review utACK fab15ff70e8db26942db83a9aab7ebf974e8b6b2 Haven't tried what code paths are reached in a fuzzer.
MarcoFalke commented at 8:08 PM on February 13, 2019: member

Great! Thanks for looking at this. If you find new coverage, don't forget to add them to https://github.com/bitcoin-core/qa-assets/tree/master/fuzz_seed_corpus/script_flags, such that progress is accumulative over all machines that run the fuzzer and new fuzzers don't have to start from zero.

Related: #15295 (comes with instructions on how to build the fuzzer)
practicalswift commented at 10:14 AM on February 14, 2019: contributor

Strong concept ACK

Thanks for adding more fuzzing targets! Very much needed!

in src/test/fuzz/script_flags.cpp:38 in fab15ff70e

  33 | +        if (!IsValidFlagCombination(verify_flags)) return;
  34 | +
  35 | +        unsigned int fuzzed_flags;
  36 | +        ds >> fuzzed_flags;
  37 | +
  38 | +        for (unsigned i = 0; i < tx.vin.size(); ++i) {

practicalswift commented at 10:15 AM on February 14, 2019:

The dropped int here intentional? Same result but looks non-idiomatic :-)

MarcoFalke referenced this in commit 743c2f461c on Feb 15, 2019
MarcoFalke merged this on Feb 15, 2019
MarcoFalke closed this on Feb 15, 2019
jamesob commented at 6:22 PM on February 15, 2019: member

Post-merge utACK https://github.com/bitcoin/bitcoin/commit/fab15ff70e8db26942db83a9aab7ebf974e8b6b2

Nice!
MarcoFalke deleted the branch on Feb 15, 2019
random-zebra referenced this in commit 44b5327e61 on May 28, 2021
kittywhiskers referenced this in commit e5e458b0d3 on Aug 2, 2021
kittywhiskers referenced this in commit cc67619a84 on Aug 5, 2021
kittywhiskers referenced this in commit 45a0e9e75f on Aug 5, 2021
PastaPastaPasta referenced this in commit 614c66d5b6 on Aug 6, 2021
kittywhiskers referenced this in commit 6f63f5791b on Aug 8, 2021
kittywhiskers referenced this in commit 0dde23949b on Aug 11, 2021
PastaPastaPasta referenced this in commit 90e7119a8b on Aug 11, 2021
5tefan referenced this in commit a8e43c1493 on Aug 12, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels