Canonicalize version string, and return in HTTP headers Server, User-Agent #154

pull jgarzik wants to merge 2 commits into bitcoin:master from jgarzik:http-version changing 5 files +38 −15
  1. jgarzik commented at 7:19 PM on April 13, 2011: contributor

    Two changes, in two commits:

    1. Make version number->string conversion consistent throughout bitcoin.

    2. Major HTTP clients send full version string in User-Agent header. Major HTTP servers send full version string in Server header. Update our RPC code to follow suit.

  2. gavinandresen commented at 2:05 AM on April 14, 2011: contributor

    Looks good

  3. jgarzik commented at 4:25 AM on April 14, 2011: contributor

    Looks good, but BlueMatt says it crashes the GUI, so that's a blocker

  4. TheBlueMatt commented at 9:23 PM on April 14, 2011: member

    Just missing a ".c_str()" in ui.cpp:1817.

  5. Ensure version number->string conversion is consistent a584320357
  6. Send/return full bitcoin version string in Server and User-Agent HTTP headers 17616eac17
  7. jgarzik commented at 8:01 AM on April 15, 2011: contributor

    Updated w/ BlueMatt's fix.

  8. gavinandresen merged this on Apr 15, 2011
  9. gavinandresen closed this on Apr 15, 2011
  10. sipa referenced this in commit 855f50ab33 on Dec 23, 2014
  11. sipa referenced this in commit 7873633b57 on Jan 5, 2015
  12. glv2 referenced this in commit f21e918caf on Mar 7, 2015
  13. TheBlueMatt referenced this in commit 582b2934e6 on Oct 20, 2015
  14. deadalnix referenced this in commit afff0155e0 on Mar 30, 2016
  15. sidhujag referenced this in commit d9cddd4ddc on May 18, 2016
  16. sidhujag referenced this in commit fc0557a4a6 on May 19, 2016
  17. rebroad referenced this in commit e64cbb9049 on Dec 7, 2016
  18. deadalnix referenced this in commit d57cae9473 on Jan 19, 2017
  19. destenson referenced this in commit d323160b64 on Nov 18, 2017
  20. lateminer referenced this in commit d9d3e231f6 on Dec 9, 2017
  21. cryptapus referenced this in commit 0e2e34ecd9 on May 31, 2019
  22. attilaaf referenced this in commit 0560421f6d on Jan 13, 2020
  23. rajarshimaitra referenced this in commit 3f2fec294a on Mar 23, 2021
  24. cryptapus referenced this in commit 9f29c5849c on May 3, 2021
  25. rajarshimaitra referenced this in commit 473a259bfa on Aug 5, 2021
  26. DrahtBot locked this on Sep 8, 2021
Contributors
jgarzikgavinandresenTheBlueMatt
Linked (view graph)
#25323 miniscript fuzzer failing after qa-assets update
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:16 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me