signed / unsigned warnings in script.h and serialize.h #1541

issue Diapolo opened this issue on June 30, 2012
  1. Diapolo commented at 1:52 PM on June 30, 2012: none

    This is the output, when compiling in Qt creator (Bitcoin-Qt) Warning:comparison between signed and unsigned integer expressions [-Wsign-compare]

    serialize.h: https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L812 https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L824 https://github.com/bitcoin/bitcoin/blob/master/src/serialize.h#L837

    script.h: https://github.com/bitcoin/bitcoin/blob/master/src/script.h#L455

    If a dev can give a hint on how to fix the warnings, I'm willing to create a patch.

  2. TheBlueMatt commented at 1:59 PM on June 30, 2012: member

    There are more warnings in master than just that, but you can see the actual warnings at http://jenkins.bluematt.me/job/Bitcoin/378/console

  3. Diapolo commented at 2:08 PM on June 30, 2012: none

    That are the only warnings left when compiling my local build, so these are the ones I could report :). Shouldn't be too hard to fix, but iterators and that stuff is not mine.

  4. TheBlueMatt referenced this in commit 467b79391f on Jul 2, 2012
  5. jgarzik closed this on Jul 4, 2012

  6. jgarzik referenced this in commit 3ee48ba20a on Jul 4, 2012
  7. nifgraup referenced this in commit d19b5dfc6b on Mar 30, 2014
  8. nifgraup referenced this in commit 30f5a16b9a on Mar 30, 2014
  9. suprnurd referenced this in commit 1c4e2946af on Dec 5, 2017
  10. DrahtBot locked this on Sep 8, 2021
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me