[0.17] backport #14409 #15445

1. 
   hebasto commented at 8:37 pm on February 19, 2019: member

   Backports #14409 to the 0.17 branch.

   #14409 makes the blocks directory net-specific by definition.

2. fanquake added the label Backport on Feb 19, 2019
3. fanquake added this to the milestone 0.17.2 on Feb 19, 2019
4. 
   fanquake commented at 1:57 am on February 21, 2019: member

   @hebasto This is missing the Github-Pull: and Rebased-From: info for each commit. See the backport.py script.
5. Make blockdir always net specific

   The blocks directory is net specific by definition.
   
   Also this prevents the side effect of calling GetBlocksDir(false) in the
   non-mainnet environment.
   
   Github-Pull: #14409
   Rebased-From: c3f1821ac788e522e7558e3575150433450dcb8c

   75bee85900
6. Improve blocksdir functional test.

   A new node should not create an unused `blocks` directory in the root of
   the data directory when `-testnet` or `-regtest` is specified.
   
   Github-Pull: #14409
   Rebased-From: e4a0c3547ed886871f8b3d51c6b4ffdb181a8b9c

   8cdd72e7e8
7. hebasto force-pushed on Feb 22, 2019
8. 
   hebasto commented at 7:26 pm on February 22, 2019: member

   @fanquake

   This is missing the Github-Pull: and Rebased-From: info for each commit. See the backport.py script.

   Thank you. Fixed.

9. 
   hebasto commented at 6:10 am on February 23, 2019: member

   @fanquake

   Is there a way to fix “The job exceeded the maximum time limit for jobs, and has been terminated.” error in Travis job?

10. 
    ken2812221 commented at 1:53 am on February 28, 2019: contributor

    Is is necessary to be backported? It seems like a breaking change.
11. 
    MarcoFalke commented at 4:31 pm on February 28, 2019: member

    I don’t think this is a breaking change. Otherwise this was missed in the original review
12. hebasto closed this on Apr 21, 2019

    ---

13. hebasto deleted the branch on Apr 21, 2019
14. hebasto restored the branch on Apr 21, 2019
15. hebasto reopened this on Apr 21, 2019

    ---

16. laanwj referenced this in commit 01a1537fe0 on Aug 29, 2019
17. 
    fanquake commented at 3:15 am on September 14, 2019: member

    Thanks, however I don’t think this needs backporting into 0.17.2.
18. fanquake closed this on Sep 14, 2019

    ---

19. hebasto deleted the branch on Jan 18, 2020
20. DrahtBot locked this on Feb 15, 2022

Contributors
hebasto fanquake ken2812221 MarcoFalke

Labels
Backport

Milestone
0.17.2