Starting bitcoin-qt with -nowallet and then opening a wallet does not show the wallet #15453

achow101 commented at 10:26 PM on February 20, 2019: member

When starting bitcoin-qt with -nowallet to explicitly not load any wallets initially, attempting to load a wallet using the Open Wallet menu option results in the wallet being loaded but the GUI does not change. The wallet is reachable via the RPC interface but the GUI still says that no wallets are loaded.

promag commented at 11:38 PM on February 20, 2019: member

Should tag with 0.18.

fanquake added this to the milestone 0.18.0 on Feb 20, 2019

fanquake added the label GUI on Feb 20, 2019

fanquake added the label Wallet on Feb 20, 2019

promag commented at 11:52 PM on February 20, 2019: member

@achow101 I fail to reproduce, mind sharing more details, Qt version etc.

jnewbery commented at 12:18 AM on February 21, 2019: member

I tested this exact scenario in the PR that added the "open wallet" menu and it worked for me.

promag commented at 12:31 AM on February 21, 2019: member

Also tested with #15450 and still works.

achow101 commented at 12:33 AM on February 21, 2019: member

Bitcoin Core version v0.17.99.0-f9775a8655 (64-bit) Qt version 5.7.1 Using Debian 9

achow101 commented at 1:18 AM on February 21, 2019: member

I built it using the depends system and this bug is not present. It seems that the issue has to do with Qt 5.7.1.

fanquake commented at 4:29 AM on February 21, 2019: member

Can confirm this issue. I compiled master inside a new Debian 9.8 vm (qt 5.7.1), a new wallet opened with the Open wallet menu doesn't display in the GUI.

debian 9 8

promag commented at 12:15 AM on February 22, 2019: member

@fanquake mind testing with same fix of #15455?

achow101 commented at 12:57 AM on February 22, 2019: member

I've tried with that patch but it does not fix this.

jonasschnelli commented at 6:34 AM on February 22, 2019: contributor

I was not able to reproduce this, not on OSX self compiled master, not on Ubuntu 18.04.1 with a nightly build (gitian build of master) nor with self compiled master on Ubuntu (Qt 5.9.5). Either a timing issue or a Qt upstream difference.

Sjors commented at 9:33 AM on February 23, 2019: member

My guess is that this is a QT 5.7 issue. @achow101 does it go away when you use the depends 5.9 version?

promag commented at 9:35 AM on February 23, 2019: member

@Sjors yes, in IRC he said it works.

promag commented at 9:36 AM on February 23, 2019: member

I'm working on a fix.

fanquake commented at 10:16 AM on March 2, 2019: member

@promag mentioned (line 197) that #15478 is a potential fix for this issue.

fanquake removed this from the milestone 0.18.0 on Mar 15, 2019

fanquake added this to the milestone 0.18.1 on Mar 15, 2019

fanquake commented at 6:24 AM on March 15, 2019: member

Moving this to the 0.18.1 milestone.

promag commented at 11:51 AM on May 28, 2019: member

@fanquake care to test with #15478?

jonasschnelli added the label Bug on May 29, 2019

fanquake commented at 2:53 AM on July 4, 2019: member

@promag is #16261 a potential fix for this?

promag commented at 1:08 PM on July 4, 2019: member

@fanquake yes I think so.

hebasto commented at 4:45 PM on July 6, 2019: member

Can confirm this bug on Debian 9.9 (Qt 5.7.1, master 8c69fae94410f54bad13be0f34d54370fddbf4b3).

Debugging info:

hebasto@debian:~/bitcoin$ QT_FATAL_WARNINGS=1 lldb ./src/qt/bitcoin-qt -- -regtest -nowallet -debug=qt
(lldb) target create "./src/qt/bitcoin-qt"
Current executable set to './src/qt/bitcoin-qt' (x86_64).
(lldb) settings set -- target.run-args  "-regtest" "-nowallet" "-debug=qt"
(lldb) run
Process 890 launched: './src/qt/bitcoin-qt' (x86_64)
Process 890 stopped
* thread [#17](/bitcoin-bitcoin/17/): tid = 912, 0x00007ffff400bfff libc.so.6`gsignal + 207, name = 'QThread', stop reason = signal SIGABRT
    frame [#0](/bitcoin-bitcoin/0/): 0x00007ffff400bfff libc.so.6`gsignal + 207
libc.so.6`gsignal:
->  0x7ffff400bfff <+207>: addq   $0x88, %rsp
    0x7ffff400c006 <+214>: movl   %r8d, %eax
    0x7ffff400c009 <+217>: popq   %rbx
    0x7ffff400c00a <+218>: retq   
(lldb) bt
error: bitcoin-qt Parsing a die that is being parsed die: 0x0112da0e: DW_TAG_subprogram getOrCreateWallet
error: bitcoin-qt 0x010f864e: DW_TAG_member '_M_local_buf' refers to type 0x011168a2 which extends beyond the bounds of 0x010f8646
* thread [#17](/bitcoin-bitcoin/17/): tid = 912, 0x00007ffff400bfff libc.so.6`gsignal + 207, name = 'QThread', stop reason = signal SIGABRT
  * frame [#0](/bitcoin-bitcoin/0/): 0x00007ffff400bfff libc.so.6`gsignal + 207
    frame [#1](/bitcoin-bitcoin/1/): 0x00007ffff400d42a libc.so.6`abort + 362
    frame [#2](/bitcoin-bitcoin/2/): 0x00007ffff632b895 libQt5Core.so.5`QMessageLogger::warning(char const*, ...) const + 341
    frame [#3](/bitcoin-bitcoin/3/): 0x00007ffff6520179 libQt5Core.so.5`QMetaMethod::invoke(QObject*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) const + 2569
    frame [#4](/bitcoin-bitcoin/4/): 0x00007ffff65258aa libQt5Core.so.5`QMetaObject::invokeMethod(QObject*, char const*, Qt::ConnectionType, QGenericReturnArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument, QGenericArgument) + 2410
    frame [#5](/bitcoin-bitcoin/5/): 0x000055555565abb8 bitcoin-qt`WalletController::getOrCreateWallet(std::unique_ptr<interfaces::Wallet, std::default_delete<interfaces::Wallet> >) [inlined] QMetaObject::invokeMethod(val9=<unavailable>, val8=<unavailable>, val7=<unavailable>, val6=<unavailable>, val5=<unavailable>, val4=<unavailable>, val3=<unavailable>, val2=<unavailable>, val1=<unavailable>, val0=<unavailable>, type=QueuedConnection, member="", obj=0x00005555571f1aa0) + 63 at qobjectdefs.h:461
    frame [#6](/bitcoin-bitcoin/6/): 0x000055555565ab79 bitcoin-qt`WalletController::getOrCreateWallet(this=0x00005555571f1aa0, wallet=unique_ptr<interfaces::Wallet, std::default_delete<interfaces::Wallet> > @ 0x00007fffb1ff8ae0) + 809 at walletcontroller.cpp:124
    frame [#7](/bitcoin-bitcoin/7/): 0x000055555565ad2e bitcoin-qt`std::_Function_handler<void(std::unique_ptr<interfaces::Wallet, std::default_delete<interfaces::Wallet> >), WalletController::WalletController(interfaces::Node&, const PlatformStyle*, OptionsModel*, QObject*)::<lambda(std::unique_ptr<interfaces::Wallet, std::default_delete<interfaces::Wallet> >)> >::_M_invoke(const std::_Any_data &const, std::unique_ptr<interfaces::Wallet, std::default_delete<interfaces::Wallet> > &&const) + 12 at walletcontroller.cpp:25

debug.log:

...
2019-07-06T12:34:51Z GUI: QMetaMethod::invoke: Unable to handle unregistered datatype 'WalletModel*'

It seems the problem is here: https://github.com/bitcoin/bitcoin/blob/8c69fae94410f54bad13be0f34d54370fddbf4b3/src/qt/walletcontroller.cpp#L118-L125 @fanquake I failed to build the Bitcoin Core with the downloaded Qt 5.7.1 on bionic. Could you give me a piece of advice?

promag commented at 2:46 PM on July 13, 2019: member

Fixed by #16348?

hebasto commented at 2:58 PM on July 13, 2019: member

@promag

Fixed by #16348?

Yes.

MarcoFalke closed this on Jul 13, 2019

pull[bot] referenced this in commit 9059a6f248 on Aug 12, 2019

sidhujag referenced this in commit 4bea2828a2 on Aug 13, 2019

Munkybooty referenced this in commit 158061f4f2 on Nov 25, 2021

Munkybooty referenced this in commit eedd48926c on Nov 30, 2021

DrahtBot locked this on Dec 16, 2021