gui: Drop unused return values in WalletFrame #15464

1. 
   promag commented at 4:29 PM on February 22, 2019: member

   This is a small cleanup since the return value of WalletFrame methods are not used. This is in line with the usual async slot declaration.

2. gui: Drop unused return values in WalletFrame 28c86de3b1
3. MarcoFalke added the label Refactoring on Feb 22, 2019
4. 
   laanwj commented at 5:27 PM on February 22, 2019: member

   The first question that comes to mind for me is: should these return values be used?

5. 
   promag commented at 5:38 PM on February 22, 2019: member

   Not currently, and if there's a need then it should be used and tagged not discarded.

6. 
   laanwj commented at 5:45 PM on February 22, 2019: member

   So the intent is to ignore errors in these functions at the moment?

7. 
   promag commented at 6:03 PM on February 22, 2019: member

   What errors?

8. 
   jonasschnelli commented at 7:30 PM on February 22, 2019: contributor

   I guess what @laanwj meant was if we should silently ignore things like if the wallet is already loaded or if we should transport that "error" to the user... I guess its captured earlier so I'm fine with this change.

9. 
   practicalswift commented at 7:31 PM on February 22, 2019: contributor

   utACK 28c86de3b11ec16ba370f07327cf5a5de0e75c99

10. 
    promag commented at 7:58 PM on February 22, 2019: member

    @jonasschnelli Yap, WalletController should validate those things, at this point these methods should simply work. I also plan to reduce those conditions so it's easier to reason about how these widgets work.

11. fanquake added the label GUI on Feb 23, 2019
12. 
    jonasschnelli commented at 5:57 AM on February 23, 2019: contributor

    utACK 28c86de3b11ec16ba370f07327cf5a5de0e75c99 (post 0.18 branch-off)

13. MarcoFalke added this to the milestone 0.19.0 on Feb 23, 2019
14. 
    DrahtBot commented at 7:06 PM on February 27, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    No conflicts as of last run.

15. 
    practicalswift commented at 7:47 PM on March 3, 2019: contributor

    re-utACK 28c86de3b11ec16ba370f07327cf5a5de0e75c99

16. MarcoFalke assigned jonasschnelli on Mar 3, 2019
17. jonasschnelli merged this on Mar 7, 2019
18. jonasschnelli closed this on Mar 7, 2019

    ---

19. jonasschnelli referenced this in commit d211edb349 on Mar 7, 2019
20. promag deleted the branch on Mar 7, 2019
21. jasonbcox referenced this in commit e6ac31ddc7 on Nov 11, 2020
22. PastaPastaPasta referenced this in commit cc14da02b4 on Sep 11, 2021
23. DrahtBot locked this on Dec 16, 2021

Milestone
0.19.0