Remove sharp edge (uninit member) when using the compiler-generated ctor for BlockFilter #15532

pull practicalswift wants to merge 1 commits into bitcoin:master from practicalswift:BlockFilterType changing 3 files +11 −2

practicalswift commented at 9:51 PM on March 4, 2019: contributor

Remove sharp edge (uninitialised member m_filter_type) when using the compiler-generated constructor for BlockFilter.

Before (but after added test):

$ src/test/test_bitcoin -t blockfilter_tests/blockfilter_basic_test
Running 1 test case...
test/blockfilter_tests.cpp(118): error: in "blockfilter_tests/blockfilter_basic_test": check default_ctor_block_filter_1.GetFilterType() == default_ctor_block_filter_2.GetFilterType() has failed [ != ]

*** 1 failure is detected in the test module "Bitcoin Test Suite"

After:

$ src/test/test_bitcoin -t blockfilter_tests/blockfilter_basic_test
Running 1 test case...

*** No errors detected

practicalswift commented at 9:52 PM on March 4, 2019: contributor

/cc @jimpo -- would you mind reviewing? :-)
MarcoFalke added the label Refactoring on Mar 4, 2019
jimpo commented at 11:38 PM on March 4, 2019: contributor

Hmm, I think it'd be better to define an INVALID = 255 BlockFilterType and set it to that.
Remove sharp edge (uninitialized m_filter_type) when using the compiler-generated constructor for BlockFilter 82c3b3f8e0
practicalswift force-pushed on Mar 5, 2019
practicalswift commented at 8:09 AM on March 5, 2019: contributor

@jimpo Thanks for reviewing. Adjusted accordingly. Please re-review :-)
jimpo commented at 6:16 PM on March 5, 2019: contributor

utACK 82c3b3f
MarcoFalke commented at 6:31 PM on March 5, 2019: member

utACK 82c3b3f8e07f0572327275841333256fa3e679e3
laanwj merged this on Mar 8, 2019
laanwj closed this on Mar 8, 2019
laanwj referenced this in commit efed9809b4 on Mar 8, 2019
practicalswift deleted the branch on Apr 10, 2021
Munkybooty referenced this in commit 83899de299 on Sep 21, 2021
christiancfifi referenced this in commit 931f3a70a7 on Oct 3, 2021
christiancfifi referenced this in commit 88c8a06516 on Oct 4, 2021
christiancfifi referenced this in commit b2c3245465 on Oct 6, 2021
christiancfifi referenced this in commit 831949f438 on Oct 11, 2021
christiancfifi referenced this in commit 52318c950f on Oct 14, 2021
pravblockc referenced this in commit 01e1fa7916 on Nov 18, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels