[test] lint-format-strings: open files sequentially (fix for OS X) #15534

1. 
   gwillen commented at 1:13 am on March 5, 2019: contributor

   In lint-format-strings, we use python argparse to read our file arguments. In this mode, argparse opens all the files simultaneously. On OS X, where the default filehandle limit is 128, this causes the lint to fail. Instead, ask argparse for our filename arguments as strings, and open them one at a time using ‘with open’.
2. In lint-format-strings, open files sequentially

   In lint-format-strings, we use python argparse to read our file arguments. In
   this mode, argparse opens all the files simultaneously. On OS X, where the
   default filehandle limit is 128, this causes the lint to fail. Instead, ask
   argparse for our filename arguments as strings, and open them one at a time
   using 'with open'.

   21be609b49
3. fanquake added the label Tests on Mar 5, 2019
4. 
   gwillen commented at 1:14 am on March 5, 2019: contributor

   I strongly recommend reviewing with ‘ignore whitespace changes’, since this PR changes the indentation of a large block of code.
5. 
   DrahtBot commented at 2:58 am on March 5, 2019: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   No conflicts as of last run.

6. 
   practicalswift commented at 7:03 am on March 5, 2019: contributor

   utACK 21be609b4947c955b93dd2be3fbc7624f6e04325

   Thanks for fixing!

7. MarcoFalke renamed this:
   In lint-format-strings, open files sequentially (fix for OS X failure)
   [test] lint-format-strings: open files sequentially (fix for OS X)
   on Mar 5, 2019
8. MarcoFalke added the label Refactoring on Mar 5, 2019
9. MarcoFalke merged this on Mar 5, 2019
10. MarcoFalke closed this on Mar 5, 2019

    ---

11. MarcoFalke referenced this in commit 4952a95358 on Mar 5, 2019
12. gwillen deleted the branch on Mar 5, 2019
13. UdjinM6 referenced this in commit 037114295c on Jul 29, 2020
14. UdjinM6 referenced this in commit 3ca9c835b3 on Jul 29, 2020
15. PastaPastaPasta referenced this in commit 27aef40091 on Jul 29, 2020
16. DrahtBot locked this on Dec 16, 2021

Contributors
gwillen DrahtBot practicalswift

Labels
Refactoring Tests