In lint-format-strings, we use python argparse to read our file arguments. In this mode, argparse opens all the files simultaneously. On OS X, where the default filehandle limit is 128, this causes the lint to fail. Instead, ask argparse for our filename arguments as strings, and open them one at a time using 'with open'.
[test] lint-format-strings: open files sequentially (fix for OS X) #15534
pull gwillen wants to merge 1 commits into bitcoin:master from gwillen:feature-fix-lint-osx changing 1 files +19 −19-
gwillen commented at 1:13 AM on March 5, 2019: contributor
-
21be609b49
In lint-format-strings, open files sequentially
In lint-format-strings, we use python argparse to read our file arguments. In this mode, argparse opens all the files simultaneously. On OS X, where the default filehandle limit is 128, this causes the lint to fail. Instead, ask argparse for our filename arguments as strings, and open them one at a time using 'with open'.
- fanquake added the label Tests on Mar 5, 2019
-
gwillen commented at 1:14 AM on March 5, 2019: contributor
I strongly recommend reviewing with 'ignore whitespace changes', since this PR changes the indentation of a large block of code.
-
DrahtBot commented at 2:58 AM on March 5, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
practicalswift commented at 7:03 AM on March 5, 2019: contributor
utACK 21be609b4947c955b93dd2be3fbc7624f6e04325
Thanks for fixing!
- MarcoFalke renamed this:
In lint-format-strings, open files sequentially (fix for OS X failure)
[test] lint-format-strings: open files sequentially (fix for OS X)
on Mar 5, 2019 - MarcoFalke added the label Refactoring on Mar 5, 2019
- MarcoFalke merged this on Mar 5, 2019
- MarcoFalke closed this on Mar 5, 2019
- MarcoFalke referenced this in commit 4952a95358 on Mar 5, 2019
- gwillen deleted the branch on Mar 5, 2019
- UdjinM6 referenced this in commit 037114295c on Jul 29, 2020
- UdjinM6 referenced this in commit 3ca9c835b3 on Jul 29, 2020
- PastaPastaPasta referenced this in commit 27aef40091 on Jul 29, 2020
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels