backport: Ensure tried collisions resolve, and allow feeler connections to existing outbound netgroups #15563

1. 
   fanquake commented at 7:07 am on March 9, 2019: member

   Backports #15486 to the 0.18 branch.
2. [addrman] Improve tried table collision logging

   Github-Pull: #15486
   Rebased-From: 4d834018e368c3481a5421891395f64aa9002185

   ceb5ab34b8
3. [net] feeler connections can be made to outbound peers in same netgroup

   Fixes a bug where feelers could be stuck trying to resolve a collision in the
   tried table that is to an address in the same netgroup as an existing outbound peer.
   
   Thanks to Muoi Tran for the original bug report and detailed debug logs to track
   this down.
   
   Github-Pull: #15486
   Rebased-From: 4991e3c813c9848d3b3957ea3ad433f02fca9e81

   78725b4893
4. [addrman] Ensure collisions eventually get resolved

   After 40 minutes, time out a test-before-evict entry and just evict without
   testing. Otherwise, if we were unable to test an entry for some reason, we
   might break using feelers altogether.
   
   Github-Pull: #15486
   Rebased-From: f71fdda3bc2e7acd2a8b74e882364866b8b0f55b

   61248cd6da
5. [addrman] Improve collision logging and address nits

   Github-Pull: #15486
   Rebased-From: 20e6ea259b222b10f066f22695a5f56c52071f63

   d6602c2018
6. fanquake added the label P2P on Mar 9, 2019
7. fanquake added the label Backport on Mar 9, 2019
8. fanquake added this to the milestone 0.18.0 on Mar 9, 2019
9. fanquake requested review from sdaftuar on Mar 9, 2019
10. 
    fanquake commented at 7:15 am on March 9, 2019: member

    Done by @laanwj in https://github.com/bitcoin/bitcoin/compare/f810f14cf61d...b80dedb59678b3b35a7808e3fc09cf0610170070.
11. fanquake closed this on Mar 9, 2019

    ---

12. fanquake deleted the branch on Mar 9, 2019
13. DrahtBot locked this on Dec 16, 2021

Contributors
fanquake

Review Requested
sdaftuar

Labels
P2P Backport

Milestone
0.18.0