Problem:
constexpr.static when they
are meant to be locally scoped variables.Solution:
constexpr when they can be.static qualifier when possible so that variables which are
meant to only be used locally are not bloating the final binary by
residing in the data segment.
Problem:
- Several items in strencodings.h/cpp are known at compile-time, but are being computed at run-time due to not being labelled as `constexpr`.
- Several items in strencodings.h/cpp are marked `static` when they are meant to be locally scoped variables.
Solution:
- Mark items `constexpr` when they can be.
- Remove `static` qualifier when possible so that variables which are
meant to only be used locally are not bloating the final binary by
residing in the `data` segment.
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Reviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
static const vs constexpr vs static constexpr for POD is a stylistic difference without any effect on the compiled binary.
Stylistic changes without rationale are generally not accepted.
143 | @@ -143,7 +144,7 @@ std::string EncodeBase64(const std::string& str) 144 | 145 | std::vector<unsigned char> DecodeBase64(const char* p, bool* pf_invalid) 146 | { 147 | - static const int decode64_table[256] = 148 | + constexpr std::array<int,256> decode64_table =
IMO there is no gain using std::array in these cases.
FWIW, this is what the C++ Core Guidelines say about the gains of using std::array:s instead of C arrays in the general case:
ES.27: Use std::array or stack_array for arrays on the stackSL.con.1: Prefer using STL array or vector instead of a C arrayAdding as a friendly general reference - not as a comment on the merits of these specific changes :-)
<!--cf906140f33d8803c4a75a2196329ecb-->Needs rebase
No activity for more than a month. Closing for now. Let me know if you want me to reopen this