tests: Teach lint-whitespace.sh to detect missing newline at end of file #15589

pull practicalswift wants to merge 2 commits into bitcoin:master from practicalswift:lint-newline-at-eof changing 1 files +23 −1

practicalswift commented at 10:37 AM on March 13, 2019: contributor

Teach lint-whitespace.sh to detect missing newline at end of file.

Accidental omission of newline at EOF is a quite common review nit which is better handled by lint-whitespace.sh :-)

Rationale: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

lint: Teach lint-whitespace.sh to detect missing newline at end of file

Accidental omission of newline at EOF is a quite common review nit which
is better handled by lint-whitespace.sh :-)

Background reading: https://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline

b37257fcbd

fanquake added the label Tests on Mar 13, 2019
practicalswift renamed this:
~~lint: Teach lint-whitespace.sh to detect missing newline at end of file~~
tests: Teach lint-whitespace.sh to detect missing newline at end of file
on Mar 13, 2019
[wip] Test: No newline at end of file fc3ffffcee
laanwj commented at 10:55 AM on March 13, 2019: member

NACK, as i've said many times before, linters exist in bitcoin's source tree to find potential and actual bugs.

Please stop trying to do otherwise, don't make me repeat myself so many times.

EOL at end of file is an irrelevant aesthetic detail, compilers don't care.
practicalswift closed this on Mar 13, 2019
practicalswift commented at 11:04 AM on March 13, 2019: contributor

@laanwj Should we remove lint-whitespace.sh?
laanwj commented at 11:06 AM on March 13, 2019: member

@practicalswift let's, just leave these things be, and focus on user problems and actual bugs
practicalswift deleted the branch on Apr 10, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

practicalswift

laanwj

Labels

Tests