rpc: Clarify decodescript RPCResult doc #15616

1. 
   MarcoFalke commented at 1:55 AM on March 18, 2019: member

   • Remove "hex" from the decodescript RPCResult doc
   • Add "segwit" to the doc

   Follow up to a6099ef319a73e2255dca77065600abb22c4f5f8 and 4f933b3d23010d3b03998460290faed97cd6f236

2. MarcoFalke added the label Docs on Mar 18, 2019
3. MarcoFalke added this to the milestone 0.19.0 on Mar 18, 2019
4. MarcoFalke force-pushed on Mar 18, 2019
5. MarcoFalke force-pushed on Mar 18, 2019
6. MarcoFalke renamed this:
   rpc: Remove hex from decodescript RPCResult doc
   rpc: Clarify decodescript RPCResult doc
   on Mar 18, 2019
7. rpc: Clarify decodescript RPCResult doc faad33ff15
8. rpc: decodescript use IsValidNumArgs over hardcoded check fa3caa1666
9. MarcoFalke force-pushed on Mar 18, 2019
10. 
    DrahtBot commented at 5:00 AM on March 18, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15452 (Replace CScriptID and CKeyID in CTxDestination with dedicated types by instagibbs)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. rpc: Mention all output types in decodescript doc fa926ec24f
12. in src/rpc/rawtransaction.cpp:621 in fa3caa1666 outdated

     625 | -            "  \"type\":\"type\", (string) The output type\n"
     626 | -            "  \"reqSigs\": n,    (numeric) The required signatures\n"
     627 | -            "  \"addresses\": [   (json array of string)\n"
     628 | -            "     \"address\"     (string) bitcoin address\n"
     629 | +            "  \"asm\":\"asm\",          (string) Script public key\n"
     630 | +            "  \"type\":\"type\",        (string) The output type\n"
    

    ---

    ---

    

    ryanofsky commented at 4:13 PM on March 20, 2019:

    In commit "rpc: Clarify decodescript RPCResult doc" (faad33ff15398159115afd4799e3c97ac3df2a3a)

    Might be nice to list possible type strings here.

    ---

    

    MarcoFalke commented at 7:57 PM on March 20, 2019:

    Done

13. ryanofsky approved
14. 
    ryanofsky commented at 4:15 PM on March 20, 2019: member

    utACK fa3caa1666a9baa856e92398a890aaddbdd98f7c. Looks like segwit field was added in #12321 and never documented.

15. ryanofsky approved
16. 
    ryanofsky commented at 5:18 PM on March 22, 2019: member

    utACK fa926ec24fb3d07de32bd8f67a297f9e4f0822a6. Only change since last review is listing possible output types in the help string using a new GetAllOutputTypes function

17. MarcoFalke merged this on Mar 28, 2019
18. MarcoFalke closed this on Mar 28, 2019

    ---

19. MarcoFalke referenced this in commit 9e7dc682e0 on Mar 28, 2019
20. MarcoFalke deleted the branch on Mar 28, 2019
21. deadalnix referenced this in commit 5160fed366 on Oct 26, 2020
22. vijaydasmp referenced this in commit aee5098577 on Oct 27, 2021
23. MarcoFalke locked this on Dec 16, 2021

Contributors

MarcoFalkeDrahtBotryanofsky

Milestone
0.19.0