Docs: Update ACK description in CONTRIBUTING.md #15626

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:update-ack-description-in-contributing-md changing 1 files +4 −1

jonatack commented at 11:06 AM on March 20, 2019: member

as per #15617 (comment).

Edit:

as per #15617 (comment) and #15626 (review).
fanquake added the label Docs on Mar 20, 2019

Doc: update ACK description in CONTRIBUTING.md

as per https://github.com/bitcoin/bitcoin/pull/15617#issuecomment-474773043 and https://github.com/bitcoin/bitcoin/pull/15626#discussion_r267286564.

0d9d2b385b

in CONTRIBUTING.md:242 in 731414d4d4 outdated

 238 | @@ -239,7 +239,10 @@ consensus to merge a pull request (remember that discussions may have been
 239 |  spread out over GitHub, mailing list and IRC discussions). The following
 240 |  language is used within pull-request comments:
 241 |  
 242 | -  - ACK means "I have tested the code and I agree it should be merged";
 243 | +  - ACK means "I have tested the code and I agree it should be merged", involving

laanwj commented at 11:09 AM on March 20, 2019:

thanks! also maybe say (t)ACK here, as people use tACK, tested ACK and ACK interchangeably with the same intent

jonatack force-pushed on Mar 20, 2019
promag commented at 6:18 PM on March 20, 2019: member

ACK 0d9d2b3.
laanwj commented at 6:45 PM on March 20, 2019: member

Looks good to me now, thanks

ACK 0d9d2b385b8c32ab422964128d10b99cfcad2612
laanwj merged this on Mar 20, 2019
laanwj closed this on Mar 20, 2019
laanwj referenced this in commit bbc436e09e on Mar 20, 2019
marcinja referenced this in commit 8cfdf0c306 on Mar 20, 2019
marcinja referenced this in commit 2f605968e9 on Mar 20, 2019
jonatack deleted the branch on Mar 21, 2019
HashUnlimited referenced this in commit 6554ceaaad on Aug 30, 2019
barrystyle referenced this in commit 57d5dd36ad on Nov 11, 2019
PastaPastaPasta referenced this in commit 58519790a0 on Jun 27, 2021
PastaPastaPasta referenced this in commit 02f8e759c1 on Jun 28, 2021
PastaPastaPasta referenced this in commit 6dacf59aed on Jun 29, 2021
PastaPastaPasta referenced this in commit e386e99f01 on Jul 1, 2021
PastaPastaPasta referenced this in commit fb8d075464 on Jul 1, 2021
PastaPastaPasta referenced this in commit 47ddb2619c on Jul 8, 2021
PastaPastaPasta referenced this in commit 368f5f0c9f on Jul 10, 2021
DrahtBot locked this on Feb 15, 2022

Contributors

Labels

Linked (view graph)

#15617 p2p: Do not relay banned IP addresses