rpc: Rename size to vsize in mempool related calls #15637

1. 
   fanquake commented at 1:02 AM on March 22, 2019: member

   #13008 rebased on master, with release notes split out.

   In getmempoolancestors, getmempooldescendants, getmempoolentry and getrawmempool RPCs size returns the virtual transaction size as defined in BIP 141. Renaming it to vsize makes it consistent with returned value and other calls such as getrawtransaction.

   Related to #11218.

2. fanquake added the label RPC/REST/ZMQ on Mar 22, 2019
3. fanquake requested review from jnewbery on Mar 22, 2019
4. fanquake requested review from MarcoFalke on Mar 22, 2019
5. fanquake force-pushed on Mar 22, 2019
6. 
   DrahtBot commented at 2:30 AM on March 22, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #14649 (RPC: add weight to mempool entry output by luke-jr)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

7. 
   MarcoFalke commented at 3:04 PM on March 23, 2019: member

   utACK e26f4551bba6776b80be8695aaec774b25e8da20

8. MarcoFalke added this to the milestone 0.19.0 on Mar 23, 2019
9. in src/rpc/blockchain.cpp:383 in e26f4551bb outdated

    377 | @@ -378,7 +378,9 @@ static UniValue getdifficulty(const JSONRPCRequest& request)
    378 |  
    379 |  static std::string EntryDescriptionString()
    380 |  {
    381 | -    return "    \"size\" : n,             (numeric) virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.\n"
    382 | +    return "    \"vsize\" : n,            (numeric) virtual transaction size as defined in BIP 141. This is different from actual serialized size for witness transactions as witness data is discounted.\n"
    383 | +           "    \"size\" : n,             (numeric) (DEPRECATED) same as vsize. Only returned if bitcoind is started with -deprecatedrpc=size\n"
    384 | +           "                              size will be completely removed in v0.19.\n"
   

   ---

   ---

   

   MarcoFalke commented at 3:05 PM on March 23, 2019:

              "                              size will be completely removed in v0.20.\n"
   

   ---

   

   fanquake commented at 4:03 AM on March 24, 2019:

   Thanks, fixed up.

10. rpc: Rename size to vsize in mempool related calls e16b6a7188
11. fanquake force-pushed on Mar 24, 2019
12. 
    MarcoFalke commented at 7:49 PM on March 25, 2019: member

    re-utACK e16b6a71880052a6f7a368d8357901b0460abaef

    Only change is to fixup the deprecation notice with the right version

13. 
    jnewbery commented at 4:31 PM on March 26, 2019: member

    utACK e16b6a71880052a6f7a368d8357901b0460abaef

    Thanks!

14. jnewbery approved
15. MarcoFalke merged this on Mar 26, 2019
16. MarcoFalke closed this on Mar 26, 2019

    ---

17. MarcoFalke referenced this in commit e14cd04abb on Mar 26, 2019
18. romanz referenced this in commit 1167cbfb04 on Apr 4, 2019
19. fanquake deleted the branch on May 7, 2019
20. vijaydasmp referenced this in commit 68c792220a on Oct 5, 2021
21. Panther0087 referenced this in commit 19e94e9d4d on Oct 8, 2021
22. vijaydasmp referenced this in commit 72b7ecd663 on Oct 12, 2021
23. vijaydasmp referenced this in commit 7627e2b014 on Nov 10, 2021
24. vijaydasmp referenced this in commit 893504beeb on Dec 5, 2021
25. vijaydasmp referenced this in commit 68c20f08c1 on Dec 6, 2021
26. vijaydasmp referenced this in commit 7b82200393 on Dec 6, 2021
27. vijaydasmp referenced this in commit 4b95057642 on Dec 13, 2021
28. vijaydasmp referenced this in commit 6f422f961a on Dec 13, 2021
29. MarcoFalke locked this on Dec 16, 2021

Contributors

fanquakeDrahtBotMarcoFalkejnewbery

Milestone
0.19.0