net: Remove unused unsanitized user agent string CNode::strSubVer #15654

pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-netUABytes changing 3 files +8 −10
  1. MarcoFalke commented at 3:37 PM on March 23, 2019: member

    I fail to see a use case for this unsanitized byte array. In fact this can easily be confused with cleanSubVer and be displayed to the user (or logged) by a simple typo that is hard to find in review.

    Further reading: https://btcinformation.org/en/developer-reference#version

  2. net: Remove unused unsanitized user agent string CNode::strSubVer fa8548c5d1
  3. DrahtBot added the label P2P on Mar 23, 2019
  4. practicalswift commented at 4:05 PM on March 23, 2019: contributor

    Concept ACK

  5. DrahtBot commented at 6:14 PM on March 23, 2019: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #14046 (net: Refactor message parsing (CNetMessage), adds flexibility by jonasschnelli)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. promag commented at 1:52 AM on March 24, 2019: member

    utACK fa8548c, good catch.

  7. practicalswift commented at 7:12 AM on March 24, 2019: contributor

    utACK fa8548c5d13957f57f9b1e20e03002600962f7f0

  8. luke-jr approved
  9. luke-jr commented at 7:18 AM on March 24, 2019: member

    utACK

  10. sipa commented at 11:39 PM on March 25, 2019: member

    utACK fa8548c5d13957f57f9b1e20e03002600962f7f0

  11. MarcoFalke merged this on Apr 4, 2019
  12. MarcoFalke closed this on Apr 4, 2019
  13. MarcoFalke referenced this in commit c83442e174 on Apr 4, 2019
  14. MarcoFalke deleted the branch on Apr 4, 2019
  15. deadalnix referenced this in commit b1693872a9 on Jun 6, 2020
  16. ftrader referenced this in commit 8849147fe1 on Aug 17, 2020
  17. PastaPastaPasta referenced this in commit 165288140f on Jun 25, 2021
  18. PastaPastaPasta referenced this in commit 7cf7e932e2 on Jun 25, 2021
  19. PastaPastaPasta referenced this in commit cacf7ae22c on Jun 25, 2021
  20. PastaPastaPasta referenced this in commit 3a75bef4af on Jun 26, 2021
  21. DrahtBot locked this on Dec 16, 2021
Contributors
MarcoFalkepracticalswiftDrahtBotpromagluke-jrsipa
Labels
P2P
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 06:15 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me