0.18: rc3 backports #15691

1. 
   MarcoFalke commented at 10:10 pm on March 28, 2019: member

   Remaining backports for rc3
2. Simplify orphan processing in preparation for interruptibility

   Github-Pull: #15644
   Rebased-From: 9453018fdc8f02d42832374bcf1d6e3a1df02281

   6355214fd7
3. [MOVEONLY] Move processing of orphan queue to ProcessOrphanTx

   Github-Pull: #15644
   Rebased-From: 6e051f3d323af1d209c02e7a4319834f1947ffa7

   bb60121da1
4. Interrupt orphan processing after every transaction

   This makes orphan processing work like handling getdata messages:
   After every actual transaction validation attempt, interrupt
   processing to deal with messages arriving from other peers.
   
   Github-Pull: #15644
   Rebased-From: 866c8058a706931f025335b3e794ed2f4d287918

   50c56f2fcf
5. MarcoFalke added the label Backport on Mar 28, 2019
6. MarcoFalke added this to the milestone 0.18.0 on Mar 28, 2019
7. 
   gmaxwell commented at 0:36 am on March 31, 2019: contributor

   ACK
8. [tests] Add test for wallet rebroadcasts

   The existing wallet_resendwallettransactions.py test only tests the
   resendwallettransactions RPC. It does not test whether transactions are
   actually rebroadcast, or whether the rebroadcast logic is called on a
   timer.
   
   This commit updates the test to not use the resendwallettransactions RPC and
   test that transactions are rebroadcast on a timer.
   
   Github-Pull: #15646
   Rebased-From: 529c1ae4a04248a46a8b4a5a63ecbb12a63ff50e

   a90db2f175
9. wallet: Move CWallet::ReacceptWalletTransactions locks to callers

   Github-Pull: #15652
   Rebased-From: 0440481c6bf5683eff669c789bdf6a306d99adc5

   ebf65666c2
10. interfaces: Add Chain::requestMempoolTransactions

    Github-Pull: #15652
    Rebased-From: 57908a739ca377d60ef224ce0f565d4412a414f4

    ed0498af28
11. wallet: Update transactions with current mempool after load

    Github-Pull: #15652
    Rebased-From: 2ebf650b2eb7a078ab60c8c4d5c726823686f549

    59716ec395
12. qa: Check unconfirmed balance after loadwallet

    Github-Pull: #15652
    Rebased-From: 4bf1b1cefa9723bf2cfa8b1a938757abc99bb17b

    95faffed26
13. 
    MarcoFalke commented at 8:55 pm on April 1, 2019: member

    Would be nice if someone could double check the cherry-picks for correctly solving the conflicts
14. 
    promag commented at 9:58 pm on April 1, 2019: member

    ACK 95faffe, well done in ed0498af2827ccf033c9a7c4f46b82424e411083 - verified all cherry picks.
15. 
    laanwj commented at 11:59 am on April 2, 2019: member

    utACK 95faffed264cf54a3b3041db2471c10f5011aabe
16. laanwj merged this on Apr 2, 2019
17. laanwj closed this on Apr 2, 2019

    ---

18. laanwj referenced this in commit 32ec900850 on Apr 2, 2019
19. MarcoFalke deleted the branch on Apr 2, 2019
20. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke gmaxwell promag laanwj

Labels
Backport

Milestone
0.18.0