Remove no-op CClientUIInterface::[signal_name]_disconnect. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. #15699

1. 
   practicalswift commented at 6:29 PM on March 29, 2019: contributor

   Resolves #15698.

   Changes:

   • Remove no-op CClientUIInterface::[signal_name]_disconnect.
   • Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly.
2. Disconnect BlockNotifyGenesisWait and RPCNotifyBlockChange properly. Remove no-op CClientUIInterface::[signal_name]_disconnect. 6dd469a3be
3. practicalswift force-pushed on Mar 29, 2019
4. 
   MarcoFalke commented at 6:44 PM on March 29, 2019: member

   utACK 6dd469a3bea60d8857ec0be625c2ef8a7716c148

   Good to remove the footgun-wrapper and call disconnect on the connection object directly without passing any arguments.

5. MarcoFalke added the label Refactoring on Mar 29, 2019
6. MarcoFalke added this to the milestone 0.19.0 on Mar 29, 2019
7. 
   DrahtBot commented at 6:57 PM on March 29, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   No conflicts as of last run.

8. MarcoFalke merged this on Apr 23, 2019
9. MarcoFalke closed this on Apr 23, 2019

   ---

10. MarcoFalke referenced this in commit 4bd7187da8 on Apr 23, 2019
11. sidhujag referenced this in commit 648b340f5c on Apr 24, 2019
12. jasonbcox referenced this in commit 248d016174 on Sep 16, 2020
13. practicalswift deleted the branch on Apr 10, 2021
14. Munkybooty referenced this in commit 07eee8e934 on Oct 2, 2021
15. Munkybooty referenced this in commit 223cc0db3b on Oct 7, 2021
16. Munkybooty referenced this in commit 419053c029 on Oct 7, 2021
17. Munkybooty referenced this in commit a1342d54be on Oct 12, 2021
18. Munkybooty referenced this in commit e0cad4bdfb on Oct 16, 2021
19. Munkybooty referenced this in commit 315b30eb55 on Oct 20, 2021
20. Munkybooty referenced this in commit 5fa430b9db on Oct 21, 2021
21. Munkybooty referenced this in commit adc1e8ed7b on Oct 23, 2021
22. PastaPastaPasta referenced this in commit 5a03c3f612 on Oct 24, 2021
23. PastaPastaPasta referenced this in commit 90c82aca85 on Oct 25, 2021
24. pravblockc referenced this in commit c5d2cbbe72 on Nov 18, 2021
25. DrahtBot locked this on Aug 16, 2022

Milestone
0.19.0