wallet: Do not add "setting" key as unknown #15709

pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:walletdb-settings changing 2 files +4 −1

Bushstar commented at 9:20 AM on March 31, 2019: contributor

When loading old wallets I get "Unknown wallet records" showing up in the log file. The key that is adding to the unknown record count is "setting", this is a known key removed in the 0.6 release of Bitcoin in the commit linked below. The "setting" key is not known to the wallet anymore, like "acentry" which is not added as an unknown record, but the "setting" key was used in previous versions of Bitcoin.

https://github.com/bitcoin/bitcoin/commit/972060ce0e9746c979ce0ddeeb997121414c1d58#diff-8094838580e1bb7a3bb8fc78dcebc733
fanquake added the label Wallet on Mar 31, 2019
DrahtBot commented at 12:01 PM on March 31, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #16475 (wallet: Enumerate walletdb keys by MarcoFalke)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

in src/wallet/walletdb.cpp:422 in 0c71eaa3ea outdated

 418 | @@ -419,7 +419,7 @@ ReadKeyValue(CWallet* pwallet, CDataStream& ssKey, CDataStream& ssValue,
 419 |                  return false;
 420 |              }
 421 |          } else if (strType != "bestblock" && strType != "bestblock_nomerkle" &&
 422 | -                strType != "minversion" && strType != "acentry") {
 423 | +                strType != "minversion" && strType != "acentry" && strType != "setting") {

jonatack commented at 4:25 PM on March 31, 2019:

Note that #15588 is already proposing to change the same line to:

strType != "minversion" && strType != "acentry" && strType != "version") {

DrahtBot added the label Needs rebase on Jul 27, 2019
Bushstar force-pushed on Jul 27, 2019
DrahtBot removed the label Needs rebase on Jul 27, 2019
DrahtBot added the label Needs rebase on Jul 30, 2019
DrahtBot commented at 5:12 AM on July 30, 2019: member

Needs rebase
fanquake renamed this:
~~Do not add setting as unknown~~
wallet: Do not add "setting" key as unknown
on Jul 30, 2019
fanquake commented at 5:17 AM on July 30, 2019: member

@achow101 | @meshcollider could one of your Concept ACK / NACK this.
Bushstar closed this on Jul 30, 2019
Bushstar force-pushed on Jul 30, 2019
Add setting as known type 914923d125
Bushstar reopened this on Jul 30, 2019
fanquake removed the label Needs rebase on Jul 30, 2019
laanwj commented at 6:23 AM on July 30, 2019: member

ACK 914923d125f5d17b39b4dc05f666d130e80a68b2, this code change is straightforward enough and I don't think it makes sense to warn about this key being present.
meshcollider commented at 8:28 AM on July 30, 2019: contributor

ACK 914923d125f5d17b39b4dc05f666d130e80a68b2
meshcollider merged this on Jul 30, 2019
meshcollider closed this on Jul 30, 2019
meshcollider referenced this in commit ff57fb4578 on Jul 30, 2019
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels

wallet: Do not add "setting" key as unknown #15709

Conflicts