importtmulti help text typo #15737

issue gwillen opened this issue on April 3, 2019
  1. gwillen commented at 10:14 PM on April 3, 2019: contributor

    The importmulti help text reads, in part:

    {                                                          (json object) If a ranged descriptor is used, this specifies the start and end of the range to import
               "start": n,                                              (numeric, optional, default=0) Start of the range to import
               "end": n,                                                (numeric, required) End of the range to import (inclusive)
    },
    

    This is a value for which a key is missing; it should be "range": { ...

  2. fanquake added the label Docs on Apr 3, 2019
  3. fanquake added the label RPC/REST/ZMQ on Apr 3, 2019
  4. fanquake commented at 5:57 AM on April 4, 2019: member

    Where is this in the Core codebase? I can't see the above in the importmulti help text.

  5. gwillen commented at 6:10 AM on April 4, 2019: contributor

    It's in importmulti in rpcdump.cpp, search for "If a ranged descriptor is used". But apparently it was not in 0.17, and the code I'm currently running is already different from HEAD, as this was refactored in #15497. I am very perplexed as to how the code I'm looking at is generating the help text I'm seeing, and I wonder if there's a bug in RPCHelpMan, but I don't know that it's worth chasing, since the code has changed at HEAD and I'm not willing to rebase up right now to see if that fixed it.

  6. MarcoFalke commented at 2:06 PM on April 4, 2019: member

    Is this a bug in 0.17 (any tag or branch) or 0.18 (any tag or branch) or master? If not, this issue should be closed.

  7. MarcoFalke commented at 2:10 PM on April 4, 2019: member

    "range" is not in 0.17 and the help text in master (should be the same for 0.18) reads:

               ...
             ],
             "range": n or [n,n],                                       (numeric or array) If a ranged descriptor is used, this specifies the end or the range (in the form [begin,end]) to import
             "internal": bool,                                          (boolean, op...
    
  8. MarcoFalke closed this on Apr 4, 2019

  9. MarcoFalke commented at 2:29 PM on April 4, 2019: member

    Thy bug report is still valid, though. Thanks for reporting!

  10. MarcoFalke reopened this on Apr 4, 2019

  11. MarcoFalke closed this on Apr 10, 2019

  12. MarcoFalke referenced this in commit 8c022e8ac4 on Apr 10, 2019
  13. DrahtBot locked this on Dec 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me