The wallet provides a getter for each "type" of balance. However, a single iteration over mapWallet is sufficient to calculate all types of balances.
wallet: Remove plethora of Get*Balance #15747
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:1903-walletBal changing 5 files +48 −92-
MarcoFalke commented at 5:27 PM on April 4, 2019: member
-
wallet: Get all balances in one call fa57411fcb
- MarcoFalke added the label Refactoring on Apr 4, 2019
- MarcoFalke added the label Wallet on Apr 4, 2019
-
DrahtBot commented at 8:10 PM on April 4, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15729 (rpc: Ignore minconf parameter in getbalance by promag)
- #15728 ([wallet] Refactor relay transactions by jnewbery)
- #15713 (refactor: Replace chain relayTransactions/submitMemoryPool by higher method by ariard)
- #15632 (Remove ResendWalletTransactions from the Validation Interface by jnewbery)
- #13756 (wallet: "avoid_reuse" wallet flag for improved privacy by kallewoof)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
Empact commented at 9:37 PM on April 4, 2019: member
-
promag commented at 10:03 PM on April 4, 2019: member
utACK fa57411.
-
meshcollider commented at 12:09 PM on April 9, 2019: contributor
- fanquake deleted a comment on Apr 9, 2019
- meshcollider merged this on Apr 9, 2019
- meshcollider closed this on Apr 9, 2019
- meshcollider referenced this in commit db2985651d on Apr 9, 2019
- MarcoFalke deleted the branch on Apr 9, 2019
- deadalnix referenced this in commit a82bb2adfa on May 22, 2020
- christiancfifi referenced this in commit 1749cf9652 on Oct 3, 2021
- christiancfifi referenced this in commit 697e60c6ae on Oct 4, 2021
- christiancfifi referenced this in commit 0c081391dd on Oct 5, 2021
- christiancfifi referenced this in commit a2ba7af2f8 on Oct 5, 2021
- christiancfifi referenced this in commit 841b039430 on Oct 6, 2021
- christiancfifi referenced this in commit 1703d26013 on Oct 6, 2021
- christiancfifi referenced this in commit 6cf1ce7042 on Oct 11, 2021
- christiancfifi referenced this in commit 68555cfd9b on Oct 11, 2021
- christiancfifi referenced this in commit f43b8216b1 on Oct 14, 2021
- christiancfifi referenced this in commit b7486c6542 on Oct 14, 2021
- christiancfifi referenced this in commit fa8300f6cc on Oct 14, 2021
- pravblockc referenced this in commit 6cf96b357b on Nov 18, 2021
- pravblockc referenced this in commit 98bf687b7f on Nov 18, 2021
- MarcoFalke locked this on Dec 16, 2021
Contributors
Labels