rpc: getrpcinfo docs #15754
pull benthecarman wants to merge 1 commits into bitcoin:master from benthecarman:rpc_get_info_doc changing 1 files +14 −2-
benthecarman commented at 5:52 am on April 5, 2019: contributorFixes #15731
-
fanquake added the label Docs on Apr 5, 2019
-
fanquake added the label RPC/REST/ZMQ on Apr 5, 2019
-
in src/rpc/server.cpp:302 in 54f7fdf7cb outdated
296@@ -297,8 +297,17 @@ static UniValue getrpcinfo(const JSONRPCRequest& request) 297 RPCHelpMan{"getrpcinfo", 298 "\nReturns details of the RPC server.\n", 299 {}, 300- RPCResults{}, 301- RPCExamples{""}, 302+ RPCResult{ 303+ "{ (json object with active commands)\n" 304+ " { (json object with information about an active command)\n"
promag commented at 6:32 am on April 5, 2019:Should have the key"active_commands":
saying it’s a json array.
benthecarman commented at 6:38 am on April 5, 2019:fixedbenthecarman force-pushed on Apr 5, 2019promag commented at 6:53 am on April 5, 2019: memberThe output should be something like
0Result: 1{ 2 "active_commands" (array) All active commands 3 [ 4 { (object) Information about an active command 5 "method" (string) The name of the RPC command 6 "duration" (numeric) The running time in microseconds 7 },... 8 ] 9}
rpc: getrpcinfo docs f4b7a2f205benthecarman force-pushed on Apr 5, 2019promag commented at 3:23 pm on April 5, 2019: memberLGTM.MarcoFalke added this to the milestone 0.18.0 on Apr 8, 2019MarcoFalke added the label Needs backport on Apr 8, 2019MarcoFalke removed the label Needs backport on Apr 8, 2019MarcoFalke removed this from the milestone 0.18.0 on Apr 8, 2019MarcoFalke added this to the milestone 0.18.1 on Apr 8, 2019MarcoFalke added the label Needs backport on Apr 8, 2019in src/rpc/server.cpp:301 in f4b7a2f205
296@@ -297,8 +297,20 @@ static UniValue getrpcinfo(const JSONRPCRequest& request) 297 RPCHelpMan{"getrpcinfo", 298 "\nReturns details of the RPC server.\n", 299 {}, 300- RPCResults{}, 301- RPCExamples{""}, 302+ RPCResult{ 303+ "{\n"
laanwj commented at 9:01 am on April 10, 2019:Maybe indent this line and the strings below it four to the right?laanwj commented at 9:01 am on April 10, 2019: memberutACK f4b7a2f2055fa52d5e02c37bed7b46599b960e2eMarcoFalke removed this from the milestone 0.18.1 on Apr 10, 2019MarcoFalke added this to the milestone 0.18.0 on Apr 10, 2019MarcoFalke merged this on Apr 10, 2019MarcoFalke closed this on Apr 10, 2019
MarcoFalke referenced this in commit e82f6ad6f2 on Apr 10, 2019benthecarman referenced this in commit 60d4621975 on Apr 11, 2019laanwj referenced this in commit f42ed1442e on Apr 15, 2019fanquake removed the label Needs backport on Apr 15, 2019benthecarman deleted the branch on Apr 16, 2019HashUnlimited referenced this in commit 0c6e9e634b on Apr 19, 2019jasonbcox referenced this in commit 6e2b7528f8 on Oct 5, 2020DrahtBot locked this on Dec 16, 2021
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 09:12 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-10-31 09:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me