UniValue result was never used.
rpc: remove unused var in rawtransaction.cpp #15755
pull Bushstar wants to merge 1 commits into bitcoin:master from Bushstar:remove-unused-var changing 1 files +0 −1-
Bushstar commented at 8:30 AM on April 5, 2019: contributor
- fanquake added the label GUI on Apr 5, 2019
-
practicalswift commented at 9:18 AM on April 5, 2019: contributor
utACK a9fe1356acf5858417a60bed2a4b88ced69b5828. Nice cleanup.
BTW, the
resultvariable on L1552 inrpc/rawtransaction.cpplooks unused too. - Bushstar force-pushed on Apr 5, 2019
-
Bushstar commented at 9:32 AM on April 5, 2019: contributor
@practicalswift good spot, I've added that other unused var to this commit to make it a tiny bit less trivial and will update the original message when I've found when the
resultvar became unused. -
DrahtBot commented at 9:57 AM on April 5, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
No conflicts as of last run.
-
Remove unused var 4831aec5b1
- Bushstar force-pushed on Apr 5, 2019
-
Bushstar commented at 10:05 AM on April 5, 2019: contributor
@practicalswift Luke-jr's commit below removes the unused variable I stumbled across. I'll remove that change to avoid the conflict. This commit is now just for the unused variable you spotted.
Label now needs changing from GUI.
- fanquake removed the label GUI on Apr 5, 2019
- fanquake added the label RPC/REST/ZMQ on Apr 5, 2019
- fanquake renamed this:
qt: remove unused var
rpc: remove unused var in rawtransaction.cpp
on Apr 5, 2019 -
practicalswift commented at 11:37 AM on April 5, 2019: contributor
utACK 4831aec5b1896c096a40ae6348deec969d4e8a03
-
promag commented at 12:50 PM on April 5, 2019: member
utACK 4831aec.
- MarcoFalke referenced this in commit 35991b162f on Apr 5, 2019
- MarcoFalke merged this on Apr 5, 2019
- MarcoFalke closed this on Apr 5, 2019
- jasonbcox referenced this in commit 448f8396b6 on Oct 5, 2020
- linuxsh2 referenced this in commit 773af564c3 on Aug 11, 2021
- DrahtBot locked this on Dec 16, 2021
Contributors
Labels