gui: Add shortcuts for tab tools #15756

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-04-tools-shortcuts changing 3 files +12 −0

promag commented at 3:23 PM on April 5, 2019: member

This makes accessing the RPC console very fast/easy. It also improves accessibility.

<img width="234" alt="Screenshot 2019-10-02 at 01 30 53" src="https://user-images.githubusercontent.com/3534524/66009867-50104300-e4b4-11e9-90b5-6b8dc961a8a1.png">
fanquake added the label GUI on Apr 5, 2019
Empact commented at 1:08 AM on April 6, 2019: member

Concept ACK - letters could be more mnemonic and stable over time because they aren't tied to the order of the list.
promag commented at 4:11 PM on April 7, 2019: member

@Empact could be, open for suggestions. Just used 1 to 4 because those are the tab indexes in the dialog.
Empact commented at 6:09 AM on April 8, 2019: member

Sure, I could go either way.
jonasschnelli commented at 7:11 AM on April 8, 2019: contributor

Concept ACK No strong opinion about numbers versus something not tied to an order.
jonasschnelli commented at 9:22 AM on April 8, 2019: contributor

Tested ACK 2e2b30b201b5670ec755237ec9e93d3c2388bf2b https://bitcoin.jonasschnelli.ch/build/1046
Empact commented at 9:08 AM on April 10, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/15756/commits/2e2b30b201b5670ec755237ec9e93d3c2388bf2b
laanwj commented at 12:23 PM on April 15, 2019: member

would it make sense to make these shortcuts application-global ? (see #15768 (comment)). I personally kind of expected pressing multiple in sequence e.g. Ctrl-1 Ctrl-2 to work.
promag commented at 1:28 PM on April 15, 2019: member

@laanwj currently it does, at least on macos. Have you tested in other OS?
promag commented at 1:30 PM on April 15, 2019: member

BTW, one could argue that these shortcuts are better fit for Overview, Send, Receive and Transactions tabs in the main window.
luke-jr commented at 6:36 PM on April 18, 2019: member

Alt-1..4 already work for the main window tabs.

I'm not sure using numbers for a different window makes sense.
promag commented at 6:52 PM on April 18, 2019: member

@luke-jr I wasn't aware of that. On macos shortcuts are usually with CMD (Qt::CTRL).

So do you suggest using letters?
luke-jr commented at 8:35 PM on April 20, 2019: member

I'm not sure it makes sense to give shortcuts for debug-window stuff. These aren't things normal users should be using. (If they are, we should promote them out of the debug window.)
promag commented at 10:21 PM on April 21, 2019: member
@luke-jr "debug window" is something the user isn't aware of. And these things are already promoted in the window menu - this PR only improves their accessibility.

My suggestion:
- on macos make CMD-[1-4] the same as ALT-[1-4]
- SHIFT-CMD-[ICNP] for these tabs (and the equivalent on other systems).
GChuf commented at 4:19 PM on August 29, 2019: contributor

Concept ACK, would really like to see this implemented. for non-macOS, I'd suggest using: Ctrl + T for console window (T for terminal) Ctrl + I for Info Ctrl + P for peers Ctrl + N for network
laanwj added the label Feature on Sep 30, 2019
promag force-pushed on Oct 2, 2019
gui: Add shortcuts for tab tools 091747b46e
DrahtBot commented at 12:28 AM on October 2, 2019: member

Needs rebase
DrahtBot added the label Needs rebase on Oct 2, 2019
promag force-pushed on Oct 2, 2019
promag commented at 12:29 AM on October 2, 2019: member

Rebased and followed @GChuf suggestion and updated screenshot.
fanquake removed the label Needs rebase on Oct 2, 2019
laanwj commented at 9:32 AM on October 2, 2019: member
Concept ACK, though it's a bit inconsistent now, at least in Linux.

When the main window is selected, the following shortcuts work:
```
Ctrl-I
Ctrl-T
Ctrl-N
Ctrl-P
```
When the debug window is selected, only the following shortcuts work:
```
Alt-I
Alt-C (so, not T)
Alt-N
Alt-P
```
GChuf commented at 11:17 AM on October 4, 2019: contributor

@promag glad you like my suggestion!

Tested 091747b46ecf06244ce2650028f1833b2e7c5062 on Ubuntu 18, can confirm CTRL shortcuts don't work when debug window is opened.

As for Alt-T / Alt-C, the only solution I can think of is renaming Console to Terminal (is that even right?) so that we could have Alt-T for consistency. Obviously, CTRL-C could be problematic.
jonasschnelli commented at 10:16 AM on October 9, 2019: contributor

Tested ACK 091747b46ecf06244ce2650028f1833b2e7c5062 - this is an improvment. Further solutions to solve the interference between the console and the shortcuts (if possible) can be done upstream (Qt) or with another PR.
jonasschnelli added this to the milestone 0.20.0 on Oct 9, 2019
jonasschnelli referenced this in commit 5cb1d938a1 on Oct 10, 2019
jonasschnelli merged this on Oct 10, 2019
jonasschnelli closed this on Oct 10, 2019
promag deleted the branch on Oct 10, 2019
sidhujag referenced this in commit fe3c9662c7 on Oct 11, 2019
MarkLTZ referenced this in commit 4c6347438a on Nov 17, 2019
jasonbcox referenced this in commit a3bf3e8b57 on Oct 28, 2020
ftrader referenced this in commit e8022382e1 on Apr 14, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Milestone
0.20.0