test: Unify testing setups for fuzz, bench, and unit tests #15788

1. 
   MarcoFalke commented at 8:03 pm on April 10, 2019: member

   Now that the fuzz tests can use the BasicTestingSetup [1], do the same for bench.

   Also move some duplicate code to a common “test/util” module.

   [1]: fuzz: Link BasicTestingSetup (shared with unit tests) #15504

2. test: Have segwit always active in (Basic)TestingSetup 666696b673
3. test: Use test_bitcoin setup in bench, Add test utils fa8685d49e
4. DrahtBot added the label Build system on Apr 10, 2019
5. DrahtBot added the label Tests on Apr 10, 2019
6. 
   practicalswift commented at 7:40 am on April 11, 2019: contributor

   Concept ACK

   Nice!

7. MarcoFalke force-pushed on Apr 11, 2019
8. scripted-diff: Rename test_bitcoin to test/setup_common

   -BEGIN VERIFY SCRIPT-
   sed -i --regexp-extended -e 's/test_bitcoin\.(h|cpp)/setup_common.\1/g' $(git grep -l test_bitcoin)
   git mv ./src/test/test_bitcoin.h   ./src/test/setup_common.h
   git mv ./src/test/test_bitcoin.cpp ./src/test/setup_common.cpp
   sed -i -e 's/BITCOIN_TEST_TEST_BITCOIN_H/BITCOIN_TEST_SETUP_COMMON_H/g' ./src/test/setup_common.h
   -END VERIFY SCRIPT-

   fa821904bf
9. MarcoFalke force-pushed on Apr 11, 2019
10. 
    DrahtBot commented at 2:13 pm on April 11, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #15778 ([wallet] Move maxtxfee from node to wallet by jnewbery)
    • #15104 (Tests: Add unit testing for the CompressScript function by mmachicao)
    • #15052 (Tests: Contract testing for the procedure AddTimeData and related fixes by mmachicao)
    • #14430 (Add more property based tests for basic bitcoin data structures by Christewart)
    • #14193 (validation: Add missing mempool locks by MarcoFalke)
    • #13751 (Utils and libraries: Drops the boost/algorithm/string/split.hpp dependency by 251Labs)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

11. scripted-diff: Bump copyright headers in test, bench

    -BEGIN VERIFY SCRIPT-
    ./contrib/devtools/copyright_header.py update ./src/bench/
    ./contrib/devtools/copyright_header.py update ./src/test/
    -END VERIFY SCRIPT-

    faf400077d
12. MarcoFalke force-pushed on Apr 11, 2019
13. 
    jonatack commented at 12:17 pm on April 12, 2019: member

    ACK https://github.com/bitcoin/bitcoin/pull/15788/commits/faf400077d0144363c2dd24187431d958fb149a9

    Reviewed changes, recompiled, ran unit tests and benchmarks. Todo: Run fuzzing.

14. 
    jonatack commented at 2:17 pm on April 12, 2019: member

    FWIW I haven’t managed to get the fuzzing to run as per doc/fuzzing.md so cannot confirm or infirm that aspect for this PR. Gist here. It’s surely something I’m doing wrong. Pointers welcome.
15. 
    MarcoFalke commented at 4:56 pm on April 12, 2019: member

    Fuzzing shouldn’t be changed by this pr, but it would help if you posted your configure line (and config log) as well as the output of make. See also doc/fuzzing
16. MarcoFalke merged this on Apr 15, 2019
17. MarcoFalke closed this on Apr 15, 2019

    ---

18. MarcoFalke referenced this in commit 78295e97b8 on Apr 15, 2019
19. MarcoFalke deleted the branch on Apr 15, 2019
20. MarcoFalke referenced this in commit 693c743a32 on Apr 18, 2019
21. deadalnix referenced this in commit 17f899673b on Mar 18, 2020
22. deadalnix referenced this in commit 213a3701e0 on Mar 18, 2020
23. deadalnix referenced this in commit a117335ddd on Mar 18, 2020
24. deadalnix referenced this in commit b6a8418acf on Mar 19, 2020
25. deadalnix referenced this in commit e289a06d60 on Mar 19, 2020
26. deadalnix referenced this in commit 6282730dd6 on Mar 19, 2020
27. deadalnix referenced this in commit 4de1bab17a on Apr 27, 2020
28. deadalnix referenced this in commit 622fa9ff28 on Apr 27, 2020
29. ftrader referenced this in commit 4d1ebac5fd on May 19, 2020
30. deadalnix referenced this in commit bf444f46b2 on May 23, 2020
31. ftrader referenced this in commit d110c08a9d on Aug 17, 2020
32. ftrader referenced this in commit db6ebe7f65 on Aug 17, 2020
33. ftrader referenced this in commit d7dda0e063 on Aug 17, 2020
34. Munkybooty referenced this in commit fe4f80a6ee on Sep 30, 2021
35. Munkybooty referenced this in commit 77ed0cb41e on Oct 7, 2021
36. Munkybooty referenced this in commit e46fef0205 on Oct 7, 2021
37. Munkybooty referenced this in commit 230fe8793d on Oct 7, 2021
38. Munkybooty referenced this in commit 1b738e74f1 on Oct 7, 2021
39. kittywhiskers referenced this in commit 92ff9c7349 on Oct 12, 2021
40. kittywhiskers referenced this in commit e19ad29bcc on Oct 12, 2021
41. kittywhiskers referenced this in commit 98b45d490b on Oct 12, 2021
42. Munkybooty referenced this in commit 45fbb95f04 on Oct 12, 2021
43. Munkybooty referenced this in commit 62aac44c4f on Oct 12, 2021
44. kittywhiskers referenced this in commit f65ebd1206 on Oct 25, 2021
45. kittywhiskers referenced this in commit cb68871d4f on Oct 25, 2021
46. kittywhiskers referenced this in commit ad203019f9 on Oct 25, 2021
47. PastaPastaPasta referenced this in commit 3f32c9f056 on Nov 1, 2021
48. pravblockc referenced this in commit 752c0138b2 on Nov 18, 2021
49. DrahtBot locked this on Dec 16, 2021

Contributors
MarcoFalke practicalswift DrahtBot jonatack

Labels
Build system Tests