depends: Purge libtool archives #15844

pull dongcarl wants to merge 4 commits into bitcoin:master from dongcarl:2019-04-depends-purge-libtool-archives changing 14 files +104 −11
  1. dongcarl commented at 5:53 pm on April 18, 2019: member 
    0We use pkg-config where we can, which generally replaces libtool at a
1higher level and does not have the same downsides as libtool. These
2archives sit in our depends tree with no purpose and pollute the final
3bitcoin build with massive overlinking.

    See here for an explanation of the various problems libtool archives can cause.

    Unrelated in every way except in spirit: -D__LIBTOOL_IS_A_FOOL__!!

    This PR is based on #16041, and therefore should be merged after #16041.

  2. dongcarl added the label Build system on Apr 18, 2019
  3. dongcarl added the label Needs gitian build on Apr 18, 2019
  4. laanwj requested review from theuni on Apr 18, 2019
  5. dongcarl force-pushed on Apr 18, 2019
  6. laanwj commented at 6:06 pm on April 18, 2019: member
    I had to do this once for an embedded project, because the la files were confusing things (as they were generated in a different environment). But I’m not sure here, do you have evidence of “massive overlinking”, what is the result of that? Does the build become slower, does the executable become larger? If so, can you show results please?
  7. dongcarl commented at 6:40 pm on April 18, 2019: member

    @laanwj

    The result is usually -lstdc++ and various dynamic linking flags we don’t want ending up in the .la files, and so when we do the final bitcoin build, we’re getting extra symbols that aren’t necessary in our ELF table. This makes make -C src check-symbols fail.

    You can expand “Old content no. 1” here for an example.

  8. theuni commented at 7:04 pm on April 18, 2019: member

    This comes at my request, so concept ACK :)

    I suspect it may flesh out a few actual bugs, where we had assumed pkg-config was doing its job.

  9. DrahtBot commented at 7:33 pm on April 18, 2019: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #16041 (depends: Build secondary deps statically. by dongcarl)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. theuni commented at 10:34 pm on April 18, 2019: member
    @dongcarl Could you try this https://github.com/theuni/bitcoin/commit/f643224b4ca147f8c127804d1c03237eee345d03 as a test fix for the new failure?
  11. dongcarl commented at 5:32 am on April 19, 2019: member

    @theuni Looking at the travis failures it’s similar to something I’ve encountered before related to _XEatDataWords which is fixed by https://github.com/freedesktop/libXext/commit/bb24f2970f2e425f4df90c9b73d078ad15a73fbb. On my local builds I’ve just upgraded the package to the earliest version that contained that fix: https://github.com/freedesktop/libXext/releases/tag/libXext-1.3.3

    I can just push another commit that bumps libXext up one minor version if that’s okay with people?

  12. theuni commented at 8:11 pm on April 19, 2019: member
    @dongcarl Hah, yes, thanks for noticing. I just assumed ours wasn’t ancient. Please include the bump with this PR, since it breaks the build without it.
  13. dongcarl commented at 10:03 pm on April 19, 2019: member

    Looking at the Travis build logs for https://github.com/bitcoin/bitcoin/pull/15844/commits/27ce43dcd512d1158c7400ac03afbdd1af2d7031, it would seem that cross builds are running into another problem that I assumed to be specific to my particular configuration. Namely, that we need to give the config flag --enable-malloc0returnsnull.

    I’ve included that config flag in https://github.com/bitcoin/bitcoin/pull/15844/commits/e5444bbd13a30448f3d811d4f1faef058f18e65a, this seems to be a common problem for cross builds of X things: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=861073

  14. fanquake commented at 2:42 pm on April 29, 2019: member

    Concept ACK

    Looks like there is still at least one issue with the 32-bit + dash [GOAL: install] [GUI: no BIP70] build here:

    0checking for QTACCESSIBILITY... yes
1checking for QTFB... yes
2checking for X11XCB... yes
3checking for QTXCBQPA... yes
4checking for static Qt plugins: -lqminimal... no
5configure: error: Could not resolve: -lqminimal

    This is the diff of /lib for a master depends build, vs this PR on macOS, will test on others:

     0@@ -28,37 +28,28 @@
 1libboost_unit_test_framework-mt.a
 2libcrypto.a
 3libdb-4.8.a
 4libdb.a
 5libdb_cxx-4.8.a
 6libdb_cxx.a
 7libevent.a
 8-libevent.la
 9libevent_core.a
10-libevent_core.la
11libevent_extra.a
12-libevent_extra.la
13libevent_pthreads.a
14-libevent_pthreads.la
15libminiupnpc.a
16libprotobuf-lite.a
17-libprotobuf-lite.la
18libprotobuf.a
19-libprotobuf.la
20-libprotoc.la
21libqrencode.a
22-libqrencode.la
23libqtharfbuzz.a
24libqtlibpng.a
25libqtpcre2.a
26librapidcheck.a
27libssl.a
28libz.a
29libzmq.a
30-libzmq.la
31pkgconfig
32pkgconfig/Qt5AccessibilitySupport.pc
33pkgconfig/Qt5CglSupport.pc
34pkgconfig/Qt5ClipboardSupport.pc
35pkgconfig/Qt5Core.pc
36pkgconfig/Qt5DBus.pc
37pkgconfig/Qt5DeviceDiscoverySupport.pc
  15. fanquake commented at 4:47 am on April 30, 2019: member

    After depends building inside a ubuntu:1804 Docker container.

      0@@ -15,25 +15,21 @@
  1libQt5Network.a
  2libQt5PrintSupport.a
  3libQt5ServiceSupport.a
  4libQt5Test.a
  5libQt5ThemeSupport.a
  6libQt5Widgets.a
  7libQt5XcbQpa.a
  8-libX11-xcb.la
  9libX11-xcb.so
 10libX11-xcb.so.1
 11libX11-xcb.so.1.0.0
 12-libX11.la
 13libX11.so
 14libX11.so.6
 15libX11.so.6.3.0
 16libXau.a
 17-libXau.la
 18-libXext.la
 19libXext.so
 20libXext.so.6
 21libXext.so.6.4.0
 22libboost_chrono-mt.a
 23libboost_filesystem-mt.a
 24libboost_prg_exec_monitor-mt.a
 25libboost_system-mt.a
 26@@ -42,154 +38,117 @@
 27libboost_timer-mt.a
 28libboost_unit_test_framework-mt.a
 29libcrypto.a
 30libdb-4.8.a
 31libdb.a
 32libdb_cxx-4.8.a
 33libdb_cxx.a
 34-libdbus-1.la
 35libdbus-1.so
 36libdbus-1.so.3
 37libdbus-1.so.3.14.11
 38libevent.a
 39-libevent.la
 40libevent_core.a
 41-libevent_core.la
 42libevent_extra.a
 43-libevent_extra.la
 44libevent_pthreads.a
 45-libevent_pthreads.la
 46-libexpat.la
 47libexpat.so
 48libexpat.so.1
 49libexpat.so.1.6.8
 50-libfontconfig.la
 51libfontconfig.so
 52libfontconfig.so.1
 53libfontconfig.so.1.9.2
 54-libfreetype.la
 55libfreetype.so
 56libfreetype.so.6
 57libfreetype.so.6.13.0
 58libminiupnpc.a
 59libprotobuf-lite.a
 60-libprotobuf-lite.la
 61libprotobuf.a
 62-libprotobuf.la
 63-libprotoc.la
 64libqrencode.a
 65-libqrencode.la
 66libqtharfbuzz.a
 67libqtlibpng.a
 68libqtpcre2.a
 69librapidcheck.a
 70libssl.a
 71-libxcb-composite.la
 72libxcb-composite.so
 73libxcb-composite.so.0
 74libxcb-composite.so.0.0.0
 75-libxcb-damage.la
 76libxcb-damage.so
 77libxcb-damage.so.0
 78libxcb-damage.so.0.0.0
 79-libxcb-dpms.la
 80libxcb-dpms.so
 81libxcb-dpms.so.0
 82libxcb-dpms.so.0.0.0
 83-libxcb-dri2.la
 84libxcb-dri2.so
 85libxcb-dri2.so.0
 86libxcb-dri2.so.0.0.0
 87-libxcb-dri3.la
 88libxcb-dri3.so
 89libxcb-dri3.so.0
 90libxcb-dri3.so.0.0.0
 91-libxcb-glx.la
 92libxcb-glx.so
 93libxcb-glx.so.0
 94libxcb-glx.so.0.0.0
 95-libxcb-present.la
 96libxcb-present.so
 97libxcb-present.so.0
 98libxcb-present.so.0.0.0
 99-libxcb-randr.la
100libxcb-randr.so
101libxcb-randr.so.0
102libxcb-randr.so.0.1.0
103-libxcb-record.la
104libxcb-record.so
105libxcb-record.so.0
106libxcb-record.so.0.0.0
107-libxcb-render.la
108libxcb-render.so
109libxcb-render.so.0
110libxcb-render.so.0.0.0
111-libxcb-res.la
112libxcb-res.so
113libxcb-res.so.0
114libxcb-res.so.0.0.0
115-libxcb-screensaver.la
116libxcb-screensaver.so
117libxcb-screensaver.so.0
118libxcb-screensaver.so.0.0.0
119-libxcb-shape.la
120libxcb-shape.so
121libxcb-shape.so.0
122libxcb-shape.so.0.0.0
123-libxcb-shm.la
124libxcb-shm.so
125libxcb-shm.so.0
126libxcb-shm.so.0.0.0
127libxcb-static.a
128-libxcb-sync.la
129libxcb-sync.so
130libxcb-sync.so.1
131libxcb-sync.so.1.0.0
132-libxcb-xevie.la
133libxcb-xevie.so
134libxcb-xevie.so.0
135libxcb-xevie.so.0.0.0
136-libxcb-xf86dri.la
137libxcb-xf86dri.so
138libxcb-xf86dri.so.0
139libxcb-xf86dri.so.0.0.0
140-libxcb-xfixes.la
141libxcb-xfixes.so
142libxcb-xfixes.so.0
143libxcb-xfixes.so.0.0.0
144-libxcb-xinerama.la
145libxcb-xinerama.so
146libxcb-xinerama.so.0
147libxcb-xinerama.so.0.0.0
148-libxcb-xkb.la
149libxcb-xkb.so
150libxcb-xkb.so.1
151libxcb-xkb.so.1.0.0
152-libxcb-xprint.la
153libxcb-xprint.so
154libxcb-xprint.so.0
155libxcb-xprint.so.0.0.0
156-libxcb-xtest.la
157libxcb-xtest.so
158libxcb-xtest.so.0
159libxcb-xtest.so.0.0.0
160-libxcb-xv.la
161libxcb-xv.so
162libxcb-xv.so.0
163libxcb-xv.so.0.0.0
164-libxcb-xvmc.la
165libxcb-xvmc.so
166libxcb-xvmc.so.0
167libxcb-xvmc.so.0.0.0
168-libxcb.la
169libxcb.so
170libxcb.so.1
171libxcb.so.1.1.0
172libz.a
173libzmq.a
174-libzmq.la
175pkgconfig
176pkgconfig/Qt5AccessibilitySupport.pc
177pkgconfig/Qt5Core.pc
178pkgconfig/Qt5DBus.pc
179pkgconfig/Qt5DeviceDiscoverySupport.pc
180pkgconfig/Qt5EventDispatcherSupport.pc
181pkgconfig/Qt5FbSupport.pc
  16. DrahtBot removed the label Needs gitian build on May 4, 2019
  17. dongcarl added the label Needs gitian build on May 15, 2019
  18. dongcarl commented at 8:11 pm on May 15, 2019: member
    Ready for re-review. Checks are passing.
  19. DrahtBot removed the label Needs gitian build on May 16, 2019
  20. theuni commented at 4:41 pm on May 16, 2019: member
    Thanks, having a look at this.
  21. dongcarl force-pushed on May 17, 2019
  22. in depends/packages/libXext.mk:9 in 61e64c2f05 outdated 
     7+$(package)_sha256_hash=b518d4d332231f313371fdefac59e3776f4f0823bcb23cf7c7305bfb57b16e35
 8 $(package)_dependencies=xproto xextproto libX11 libXau
 9 
10 define $(package)_set_vars
11-  $(package)_config_opts=--disable-static
12+  $(package)_config_opts=--disable-static --enable-malloc0returnsnull
    theuni commented at 8:16 pm on May 20, 2019:

    I looked into this a few weeks back, and I believe this is auto-detected, but we manage to get it wrong.

    Could you please explain exactly why this is necessary? I’m afraid we’re accidentally building against system files.

    dongcarl commented at 8:46 pm on May 20, 2019:

    I mentioned this a little here: #15844 (comment)

    Also, it’s recommended when cross-compiling here: https://www.x.org/wiki/CrossCompilingXorg/

    Not 100% sure what you mean by “accidentally building against system files”?

    theuni commented at 8:58 pm on May 20, 2019:

    You’re completely right, thank you.

    Could you add that link (or c/p the quote) as a comment? It’s very helpful to know that it’s for bypassing an AC_RUN_IFELSE.

    dongcarl commented at 10:29 pm on May 20, 2019:
    Actually, after looking at libXext’s source I believe the stricter --disable-malloc0returnsnull works as well (I also confirmed thru a gitian build). I’ll update this.
  23. in depends/packages/expat.mk:8 in 61e64c2f05 outdated 
    4@@ -5,7 +5,8 @@ $(package)_file_name=$(package)-$($(package)_version).tar.bz2
5 $(package)_sha256_hash=17b43c2716d521369f82fc2dc70f359860e90fa440bea65b3b85f0b246ea81f2
6 
7 define $(package)_set_vars
8-$(package)_config_opts=--disable-static --without-docbook
9+  $(package)_config_opts=--disable-shared --without-docbook
    theuni commented at 8:30 pm on May 20, 2019:
    I think this is a remnant of the qt4 days. I can’t recall why it would’ve been necessary, but I agree that this is correct now.
  24. dongcarl force-pushed on May 22, 2019
  25. dongcarl force-pushed on May 22, 2019
  26. dongcarl commented at 1:31 am on May 22, 2019: member
    Updated with some commentary to help future cross-compilation target architectures/libcs.
  27. DrahtBot added the label Needs rebase on May 22, 2019
  28. MarcoFalke deleted a comment on May 22, 2019
  29. MarcoFalke deleted a comment on May 22, 2019
  30. MarcoFalke added the label Needs gitian build on May 22, 2019
  31. dongcarl force-pushed on May 22, 2019
  32. dongcarl commented at 7:43 pm on May 22, 2019: member
    Rebased.
  33. DrahtBot removed the label Needs rebase on May 22, 2019
  34. DrahtBot commented at 10:24 pm on May 22, 2019: member

    Gitian builds for commit 3001cc61cf11e016c403ce83c9cbcfd3efcbcfd9 (master):

    Gitian builds for commit fbf6a3e8ceaa2593f6fb169e8c2f520f25588fe4 (master and this pull):

  35. DrahtBot removed the label Needs gitian build on May 22, 2019
  36. in depends/packages/libXext.mk:32 in 716afd6a33 outdated 
    30+  # optional action-if-cross-compiling argument and configure prints an error
31+  # message and exits as documented in the autoconf manual. Prior to this
32+  # commit, the AC_RUN_IFELSE block had an action-if-cross-compiling argument
33+  # which set the more pessimistic default value MALLOC_ZERO_RETURNS_NULL=yes.
34+  # This is why the flag was not required prior to libXext 1.3.3.
35+  $(package)_config_opts=--disable-static --disable-malloc0returnsnull
    fanquake commented at 6:09 pm on May 24, 2019:

    I’ve only looked into this briefly, but why does --disable-malloc0returnsnull only get passed to libXext?

    With this change, building depends on Debian I’m seeing:

    0Configuring libX11...
1checking whether malloc(0) returns NULL... yes
2
3Configuring libXext...
4checking whether malloc(0) returns NULL... no

    Does this matter?

    dongcarl commented at 6:16 pm on May 24, 2019:
    @fanquake Ah, that’s the only place where I found problems. Looking at the libX11 aclocal.m4, they haven’t updated their xorg-macros yet so no problems yet. We should add --disable-malloc0returnsnull there as well just to future-proof. You didn’t see any other malloc(0) checks other than these two?
    fanquake commented at 6:21 pm on May 24, 2019:
    I haven’t seen any other malloc(0) checks 👍.
  37. fanquake commented at 6:22 pm on May 24, 2019: member

    tACK 716afd6

    .las all seem to be removed, and we pick up a libexpat.a because of 716afd6.

    Building on macOS 10.14.x:

     0libboost_unit_test_framework-mt.a
 1libcrypto.a
 2libdb-4.8.a
 3libdb.a
 4libdb_cxx-4.8.a
 5libdb_cxx.a
 6libevent.a
 7-libevent.la
 8libevent_core.a
 9-libevent_core.la
10libevent_extra.a
11-libevent_extra.la
12libevent_pthreads.a
13-libevent_pthreads.la
14libminiupnpc.a
15libprotobuf-lite.a
16-libprotobuf-lite.la
17libprotobuf.a
18-libprotobuf.la
19-libprotoc.la
20libqrencode.a
21-libqrencode.la
22libqtharfbuzz.a
23libqtlibpng.a
24libqtpcre2.a
25librapidcheck.a
26libssl.a
27libz.a
28libzmq.a
29-libzmq.la
30pkgconfig
31pkgconfig/Qt5AccessibilitySupport.pc
32pkgconfig/Qt5CglSupport.pc
33pkgconfig/Qt5ClipboardSupport.pc
34pkgconfig/Qt5Core.pc
35pkgconfig/Qt5DBus.pc
36pkgconfig/Qt5DeviceDiscoverySupport.pc

    Building on Debian 9.9:

      0libQt5Network.a
  1libQt5PrintSupport.a
  2libQt5ServiceSupport.a
  3libQt5Test.a
  4libQt5ThemeSupport.a
  5libQt5Widgets.a
  6libQt5XcbQpa.a
  7-libX11-xcb.la
  8libX11-xcb.so
  9libX11-xcb.so.1
 10libX11-xcb.so.1.0.0
 11-libX11.la
 12libX11.so
 13libX11.so.6
 14libX11.so.6.3.0
 15libXau.a
 16-libXau.la
 17-libXext.la
 18libXext.so
 19libXext.so.6
 20libXext.so.6.4.0
 21libboost_chrono-mt.a
 22libboost_filesystem-mt.a
 23libboost_prg_exec_monitor-mt.a
 24libboost_system-mt.a
 25@@ -42,155 +38,115 @@
 26libboost_timer-mt.a
 27libboost_unit_test_framework-mt.a
 28libcrypto.a
 29libdb-4.8.a
 30libdb.a
 31libdb_cxx-4.8.a
 32libdb_cxx.a
 33-libdbus-1.la
 34libdbus-1.so
 35libdbus-1.so.3
 36libdbus-1.so.3.14.11
 37libevent.a
 38-libevent.la
 39libevent_core.a
 40-libevent_core.la
 41libevent_extra.a
 42-libevent_extra.la
 43libevent_pthreads.a
 44-libevent_pthreads.la
 45-libexpat.la
 46-libexpat.so
 47-libexpat.so.1
 48-libexpat.so.1.6.8
 49-libfontconfig.la
 50+libexpat.a
 51libfontconfig.so
 52libfontconfig.so.1
 53libfontconfig.so.1.9.2
 54-libfreetype.la
 55libfreetype.so
 56libfreetype.so.6
 57libfreetype.so.6.13.0
 58libminiupnpc.a
 59libprotobuf-lite.a
 60-libprotobuf-lite.la
 61libprotobuf.a
 62-libprotobuf.la
 63-libprotoc.la
 64libqrencode.a
 65-libqrencode.la
 66libqtharfbuzz.a
 67libqtlibpng.a
 68libqtpcre2.a
 69librapidcheck.a
 70libssl.a
 71-libxcb-composite.la
 72libxcb-composite.so
 73libxcb-composite.so.0
 74libxcb-composite.so.0.0.0
 75-libxcb-damage.la
 76libxcb-damage.so
 77libxcb-damage.so.0
 78libxcb-damage.so.0.0.0
 79-libxcb-dpms.la
 80libxcb-dpms.so
 81libxcb-dpms.so.0
 82libxcb-dpms.so.0.0.0
 83-libxcb-dri2.la
 84libxcb-dri2.so
 85libxcb-dri2.so.0
 86libxcb-dri2.so.0.0.0
 87-libxcb-dri3.la
 88libxcb-dri3.so
 89libxcb-dri3.so.0
 90libxcb-dri3.so.0.0.0
 91-libxcb-glx.la
 92libxcb-glx.so
 93libxcb-glx.so.0
 94libxcb-glx.so.0.0.0
 95-libxcb-present.la
 96libxcb-present.so
 97libxcb-present.so.0
 98libxcb-present.so.0.0.0
 99-libxcb-randr.la
100libxcb-randr.so
101libxcb-randr.so.0
102libxcb-randr.so.0.1.0
103-libxcb-record.la
104libxcb-record.so
105libxcb-record.so.0
106libxcb-record.so.0.0.0
107-libxcb-render.la
108libxcb-render.so
109libxcb-render.so.0
110libxcb-render.so.0.0.0
111-libxcb-res.la
112libxcb-res.so
113libxcb-res.so.0
114libxcb-res.so.0.0.0
115-libxcb-screensaver.la
116libxcb-screensaver.so
117libxcb-screensaver.so.0
118libxcb-screensaver.so.0.0.0
119-libxcb-shape.la
120libxcb-shape.so
121libxcb-shape.so.0
122libxcb-shape.so.0.0.0
123-libxcb-shm.la
124libxcb-shm.so
125libxcb-shm.so.0
126libxcb-shm.so.0.0.0
127libxcb-static.a
128-libxcb-sync.la
129libxcb-sync.so
130libxcb-sync.so.1
131libxcb-sync.so.1.0.0
132-libxcb-xevie.la
133libxcb-xevie.so
134libxcb-xevie.so.0
135libxcb-xevie.so.0.0.0
136-libxcb-xf86dri.la
137libxcb-xf86dri.so
138libxcb-xf86dri.so.0
139libxcb-xf86dri.so.0.0.0
140-libxcb-xfixes.la
141libxcb-xfixes.so
142libxcb-xfixes.so.0
143libxcb-xfixes.so.0.0.0
144-libxcb-xinerama.la
145libxcb-xinerama.so
146libxcb-xinerama.so.0
147libxcb-xinerama.so.0.0.0
148-libxcb-xkb.la
149libxcb-xkb.so
150libxcb-xkb.so.1
151libxcb-xkb.so.1.0.0
152-libxcb-xprint.la
153libxcb-xprint.so
154libxcb-xprint.so.0
155libxcb-xprint.so.0.0.0
156-libxcb-xtest.la
157libxcb-xtest.so
158libxcb-xtest.so.0
159libxcb-xtest.so.0.0.0
160-libxcb-xv.la
161libxcb-xv.so
162libxcb-xv.so.0
163libxcb-xv.so.0.0.0
164-libxcb-xvmc.la
165libxcb-xvmc.so
166libxcb-xvmc.so.0
167libxcb-xvmc.so.0.0.0
168-libxcb.la
169libxcb.so
170libxcb.so.1
171libxcb.so.1.1.0
172libz.a
173libzmq.a
174-libzmq.la
175pkgconfig
176pkgconfig/Qt5AccessibilitySupport.pc
177pkgconfig/Qt5Core.pc
178pkgconfig/Qt5DBus.pc
179pkgconfig/Qt5DeviceDiscoverySupport.pc
180pkgconfig/Qt5EventDispatcherSupport.pc
181pkgconfig/Qt5FbSupport.pc
  38. dongcarl force-pushed on May 24, 2019
  39. chefsaroar approved
  40. dongcarl commented at 6:24 pm on May 24, 2019: member
    Updated to also enforce the stricter --disable-malloc0returnsnull on libX11. Many thanks to @fanquake for his diligent review!
  41. fanquake approved
  42. fanquake commented at 6:28 pm on May 24, 2019: member
    re-tACK 6ef57ad
  43. depends: Build secondary deps statically. 
    Secondary dependencies don't need to be shared.
    14209286df
  44. depends: Purge libtool archives 
    We use pkg-config where we can, which generally replaces libtool at a
higher level and does not have the same downsides as libtool. These
archives sit in our depends tree with no purpose and pollute the final
bitcoin build with massive overlinking.
    683b7d7a3f
  45. depends: libXext: Bump to 1.3.3 to fix _XEatDataWords 
    Compilation error for _XEatDataWords fixed in bb24f29, first included in
libXext 1.3.3.
    0e752637a2
  46. depends: libX*: --disable-malloc0returnsnull in conf 8541cbea29
  47. dongcarl force-pushed on May 28, 2019
  48. dongcarl commented at 3:07 pm on May 28, 2019: member

    Update: Rebase on #16041.

    Sorry for updating this so often, want to make sure that once people with merge access approve, the whole process is smooth.

  49. laanwj commented at 2:38 pm on June 5, 2019: member
    ACK 8541cbea2, code changes look good to me
  50. laanwj merged this on Jun 5, 2019
  51. laanwj closed this on Jun 5, 2019
  52. laanwj referenced this in commit 03858b23fe on Jun 5, 2019
  53. sidhujag referenced this in commit 676f25849d on Jun 6, 2019
  54. deadalnix referenced this in commit 4e1ea4c5cb on Apr 1, 2020
  55. zkbot referenced this in commit e3d5ddbef4 on Oct 8, 2020
  56. zkbot referenced this in commit 6e4090d840 on Oct 8, 2020
  57. ftrader referenced this in commit 076e67d4e2 on Aug 13, 2021
  58. DrahtBot locked this on Dec 16, 2021


dongcarl laanwj theuni DrahtBot fanquake chefsaroar

Labels
Build system

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 18:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me