Resolve the qt/guiutil <-> qt/optionsmodel CD #15874

pull l2a5b1 wants to merge 1 commits into bitcoin:master from l2a5b1:patch/resolve-guiutil-optionsmodel-cd changing 6 files +16 −18
  1. l2a5b1 commented at 11:52 AM on April 23, 2019: contributor

    This pull request attempts to resolve the qt/guiutil <-> qt/optionsmodel circular dependency.

    The Intro class in qt/intro has a static member function getDefaultDataDirectory which is used by qt/optionsmodel and creates the circular dependency qt/guiutil -> qt/walletmodel -> qt/optionsmodel -> qt/intro -> qt/guiutil.

    This circular dependency is resolved by moving Intro::getDefaultDataDirectory to GUIUtil::getDefaultDataDirectory without modifying the implementation.

  2. Resolve the qt/guiutil <-> qt/optionsmodal CD
    This pull request attempts to resolve the `qt/guiutil` <-> `qt/optionsmodel`
circular dependency.

The circular dependency is resolved by moving the `Intro::getDefaultDataDirectory`
member function to `GUIUtil::getDefaultDataDirectory`.
    fa1c8e2978
  3. fanquake added the label GUI on Apr 23, 2019
  4. fanquake added the label Refactoring on Apr 23, 2019
  5. MarcoFalke commented at 11:58 AM on April 23, 2019: member

    utACK fa1c8e297825fbaeda049c8bf36f39de919a9989

    <details><summary>Show signature</summary>

    -----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

utACK fa1c8e297825fbaeda049c8bf36f39de919a9989
-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
pUiIzAv/endRNVDkBjfTJYf56szd0G4hoPnRhtZU4mtron5eJSWrdQDdlM5+pfPY
FGo00RN8YxhTc3E0SQ+5P6ewUXQ0xYkqtMtfEvrkIEfbYQPdmZ6iaBBLOuxcqZsX
duK2VQLnwMtmXcJpkKw8QvpLXXi7tEeWjsG4lQ76Ra5Qda0ENrDt0Yej04IPzDsY
kOPyVFmEDBZpU5MY7EVWVAU/u5jIbIpkKyTPz8LFY9RfD1tTNmzshrKhmxhhaEwJ
5iPdcOjMjpKbyj7ZQ9MemCfGSO5eNwoirIAg+367m/bW6b/7r+SsPTP7zV+HFdXW
4iLJv3+pLp2PE5BF1cnzLiWmrcfaaXOzMbritPnbuVqLUhRQDFf8ld3FPin+UPlp
JVwjSNwBeYD+oUTysBgry3glpux8x4hfB8LNIEmKlCnsEf68+vn+bLLQtxa42zlq
pRhP6bQsmh1r25WIRLZUqNC4oLsS/1fyt4jtLaOLRnl8jLfACz0z9qh40fkLGgdY
GL1g75Q6
=kY2g
-----END PGP SIGNATURE-----

    </details>

  6. practicalswift commented at 12:08 PM on April 23, 2019: contributor

    Concept ACK

    Thanks for getting rid of these!

  7. promag commented at 12:13 PM on April 23, 2019: member

    utACK fa1c8e2.

  8. hebasto commented at 1:31 PM on April 23, 2019: member

    utACK fa1c8e297825fbaeda049c8bf36f39de919a9989

  9. practicalswift commented at 1:33 PM on April 23, 2019: contributor

    utACK fa1c8e297825fbaeda049c8bf36f39de919a9989

  10. jonasschnelli commented at 4:05 PM on April 23, 2019: contributor

    utACK fa1c8e297825fbaeda049c8bf36f39de919a9989

  11. jonasschnelli renamed this:
    Resolve the qt/guiutil <-> qt/optionsmodal CD
    Resolve the qt/guiutil <-> qt/optionsmodel CD
    on Apr 23, 2019
  12. jonasschnelli merged this on Apr 23, 2019
  13. jonasschnelli closed this on Apr 23, 2019
  14. jonasschnelli referenced this in commit e9e777e21b on Apr 23, 2019
  15. Fabcien referenced this in commit fc8c7fd5b1 on Jan 14, 2021
  16. Munkybooty referenced this in commit c74f066350 on Oct 1, 2021
  17. Munkybooty referenced this in commit 2a1ae639e2 on Oct 7, 2021
  18. Munkybooty referenced this in commit b693e2f0ae on Oct 7, 2021
  19. Munkybooty referenced this in commit 68f32512c8 on Oct 12, 2021
  20. Munkybooty referenced this in commit 810dc6f670 on Oct 16, 2021
  21. Munkybooty referenced this in commit 981438496b on Oct 20, 2021
  22. Munkybooty referenced this in commit 5d9ea253b7 on Oct 21, 2021
  23. Munkybooty referenced this in commit bc6cd4ff43 on Oct 23, 2021
  24. Munkybooty referenced this in commit 594aa4f824 on Oct 26, 2021
  25. Munkybooty referenced this in commit 2a4d79499b on Oct 28, 2021
  26. Munkybooty referenced this in commit 6590ce3394 on Nov 12, 2021
  27. Munkybooty referenced this in commit e324e764ef on Nov 13, 2021
  28. Munkybooty referenced this in commit 4f03473dbd on Nov 14, 2021
  29. pravblockc referenced this in commit 22d2de800b on Nov 18, 2021
  30. DrahtBot locked this on Dec 16, 2021
Contributors
l2a5b1MarcoFalkepracticalswiftpromaghebastojonasschnelli
Labels
GUIRefactoring
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 18:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me