BitcoinTestFramework.main already loads and stores config.ini on the object itself; just access that instead of re-reading the file to check for features
QA: Avoid re-reading config.ini unnecessarily #15895
pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:redundant_configini changing 1 files +3 −12-
luke-jr commented at 8:40 PM on April 25, 2019: member
-
a014373d81
QA: Avoid re-reading config.ini unnecessarily
BitcoinTestFramework.main already loads and stores config.ini on the object itself; just access that instead of re-reading the file to check for features
- luke-jr force-pushed on Apr 25, 2019
-
practicalswift commented at 9:07 PM on April 25, 2019: contributor
utACK a014373d81534c9df4a2cbac0f74181e708da3cc
- DrahtBot added the label Tests on Apr 25, 2019
-
DrahtBot commented at 10:13 PM on April 25, 2019: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #15876 ([rpc] signer bump fee by Sjors)
- #15382 ([util] add runCommandParseJSON by Sjors)
- #14912 ([WIP] External signer support (e.g. hardware wallet) by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
-
hebasto commented at 5:11 AM on April 26, 2019: member
utACK a014373d81534c9df4a2cbac0f74181e708da3cc
- MarcoFalke merged this on Apr 26, 2019
- MarcoFalke closed this on Apr 26, 2019
- MarcoFalke referenced this in commit f73a3c618b on Apr 26, 2019
-
promag commented at 1:50 PM on April 26, 2019: member
utACK a014373.
- jasonbcox referenced this in commit c928ec6217 on Oct 6, 2020
- Munkybooty referenced this in commit 314057e19c on Oct 3, 2021
- kittywhiskers referenced this in commit 0e0536b91f on Dec 4, 2021
- kittywhiskers referenced this in commit 2b1ca81003 on Dec 8, 2021
- kittywhiskers referenced this in commit 2de2d71a66 on Dec 8, 2021
- kittywhiskers referenced this in commit 514868589b on Dec 12, 2021
- kittywhiskers referenced this in commit 6d17fa0768 on Dec 13, 2021
- kittywhiskers referenced this in commit 61bd3cdeab on Dec 13, 2021
- kittywhiskers referenced this in commit 894fd44225 on Dec 13, 2021
- DrahtBot locked this on Dec 16, 2021
