wallet: log on rescan completion #15901

1. 
   andrewtoth commented at 4:44 PM on April 26, 2019: contributor

   Currently there is nothing logged when a rescan completes successfully. This leaves the last log message something like:

    Still rescanning. At block 573037. Progress=0.998415
   

   It is unclear when the rescan actually finished. This adds a Rescan completed. message to make it more clear.

2. in src/wallet/wallet.cpp:1867 in 9a5ca800ba outdated

   1861 | @@ -1862,6 +1862,8 @@ CWallet::ScanResult CWallet::ScanForWalletTransactions(const uint256& start_bloc
   1862 |          } else if (block_height && chain().shutdownRequested()) {
   1863 |              WalletLogPrintf("Rescan interrupted by shutdown request at block %d. Progress=%f\n", *block_height, progress_current);
   1864 |              result.status = ScanResult::USER_ABORT;
   1865 | +        } else {
   1866 | +            WalletLogPrintf("Rescan completed.\n");
   1867 |          }
   1868 |      }
   

   ---

   ---

   

   MarcoFalke commented at 4:56 PM on April 26, 2019:

   style-nit: Could add a commit to remove this scope (and the 4 extraneous spaces that precede the lines)?

   ---

   

   andrewtoth commented at 5:08 PM on April 26, 2019:

   I added the commit to do that, but the diff is pretty big.

3. MarcoFalke approved
4. 
   MarcoFalke commented at 4:56 PM on April 26, 2019: member

   utACK 9a5ca800bad2d2e5035d262057437612efa50eb0

5. MarcoFalke added the label Docs on Apr 26, 2019
6. MarcoFalke added the label Wallet on Apr 26, 2019
7. MarcoFalke removed the label Docs on Apr 26, 2019
8. MarcoFalke added the label Utils/log/libs on Apr 26, 2019
9. 
   DrahtBot commented at 5:52 PM on April 26, 2019: member

   <!--e57a25ab6845829454e8d69fc972939a-->

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   <!--174a7506f384e20aa4161008e828411d-->

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #15730 (rpc: Show scanning details in getwalletinfo by promag)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

10. 
    MarcoFalke commented at 7:10 PM on April 26, 2019: member

    Checked that the second commit is only removing a scope and whitespace.

    utACK 34e78fdcd985cf009b29911ce94e7560a063a681

    <details><summary>Show signature</summary>

    -----BEGIN PGP SIGNED MESSAGE-----
    Hash: SHA512
    
    utACK 34e78fdcd985cf009b29911ce94e7560a063a681
    -----BEGIN PGP SIGNATURE-----
    
    iQGzBAEBCgAdFiEE+rVPoUahrI9sLGYTzit1aX5ppUgFAlwqrYAACgkQzit1aX5p
    pUiAmQwApeg172htEwBZh4j0Wc17e9Hc0j/KLT2Lb4VEdE9z4IYrPpVVariSmRPP
    fd/ZVWOu+8t3rwbcoq/tAXMPHJuElZ+isxyKK7huF0n4HepD5h8qc9HbvG8hLzEx
    XP2hVNazJePrPF7LfUK1iawIseofe3i/FMQAaeInT+8Q0P/FDz8wU+7zFbJKFl6A
    tRnGPERRtSS8PjNjm3NYkNDVHTRXYDQVka0sQb3WEqK/DyTFXKIxYDcbWUiwscJJ
    DAv52Is5p5vTFZGMa7/hFmgL0pgEtE8gt47asmf7oE+yd3LdYvYcdG8AtI6CjpDO
    eg67WVmqffuwV/nSPsf/DdYYYk0rEYRJmq+PzWvxpHfvmQKZH+cuiVvnOXR4FcnM
    bmJprtrHSyvduKtksaGnu9EIT2I8GNqRtyIAlgLzEWQZjYlTUgVTZ4Vuo9fGMv3H
    ym2Wr95VmGKQYOpuhwIMaqQpSeHqA8F4fPA6PZrhthK0zR4zXTCotLTfyNCKl8JS
    PFHQv/Vm
    =vukP
    -----END PGP SIGNATURE-----
    

    </details>

11. MarcoFalke added this to the milestone 0.19.0 on Apr 26, 2019
12. 
    meshcollider commented at 3:25 AM on April 27, 2019: contributor

    Concept ACK

13. 
    Empact commented at 6:58 AM on April 27, 2019: member

    nit: Looking at the callers, this one already logs the success: https://github.com/bitcoin/bitcoin/blob/703414994aa46c8f7d37ff66c77573ae6e7dcb20/src/wallet/wallet.cpp#L4233

14. andrewtoth force-pushed on Apr 27, 2019
15. wallet: log on rescan completion 6ad372a973
16. remove extraneous scope 1b602f6fed
17. andrewtoth force-pushed on Apr 27, 2019
18. 
    andrewtoth commented at 2:17 PM on April 27, 2019: contributor

    @Empact I removed the logging from that caller, and added the time check to the log for every caller.

19. 
    Empact commented at 11:10 PM on April 27, 2019: member

    utACK https://github.com/bitcoin/bitcoin/pull/15901/commits/1b602f6fed2a6a03fd4d463bc56fa9eb0c4c779c

20. 
    meshcollider commented at 12:07 AM on April 28, 2019: contributor

    utACK https://github.com/bitcoin/bitcoin/pull/15901/commits/1b602f6fed2a6a03fd4d463bc56fa9eb0c4c779c

21. meshcollider merged this on Apr 28, 2019
22. meshcollider closed this on Apr 28, 2019

    ---

23. meshcollider referenced this in commit bdd7217f2c on Apr 28, 2019
24. andrewtoth deleted the branch on Apr 28, 2019
25. kittywhiskers referenced this in commit 251ec799e2 on Dec 4, 2021
26. kittywhiskers referenced this in commit 0bbbb04ce3 on Dec 8, 2021
27. kittywhiskers referenced this in commit 971b0991bf on Dec 8, 2021
28. kittywhiskers referenced this in commit c22c97ceab on Dec 12, 2021
29. kittywhiskers referenced this in commit 704d05820d on Dec 13, 2021
30. kittywhiskers referenced this in commit 8cdb62fb25 on Dec 13, 2021
31. kittywhiskers referenced this in commit a44b981852 on Dec 13, 2021
32. DrahtBot locked this on Dec 16, 2021

Contributors

andrewtothMarcoFalkeDrahtBotmeshcolliderEmpact

Milestone
0.19.0