GUI: Move QRImageWidget to its own file-pair #15928

pull luke-jr wants to merge 2 commits into bitcoin:master from luke-jr:split_qrencoder changing 7 files +193 −154
  1. luke-jr commented at 5:21 AM on May 1, 2019: member

    For at least QR-code based pairing of mobile wallets with nodes, it will be desirable to render QR codes even without wallet support.

    Therefore, this prepares by moving the QRImageWidget out of a wallet-specific file into its own qrencoder file-pair.

  2. fanquake added the label GUI on May 1, 2019
  3. luke-jr force-pushed on May 1, 2019
  4. GUI: Refactor actual QR code rendering into new QRImageWidget::setQR 77851ab682
  5. luke-jr force-pushed on May 1, 2019
  6. laanwj commented at 10:03 AM on May 1, 2019: member

    concept ACK, though I'd prefer naming the pair qrimagewidget.(cpp|h) so that the files are named the same as the class

  7. MarcoFalke added the label Build system on May 1, 2019
  8. MarcoFalke added the label Refactoring on May 1, 2019
  9. jonasschnelli commented at 8:31 AM on May 2, 2019: contributor

    Concept ACK @luke-jr can you elaborate a bit on the possible non-BIP21 QRCode usages?

  10. luke-jr commented at 9:17 AM on May 2, 2019: member

    The end goal is something like #15428

  11. GUI: Move QRImageWidget to its own file-pair fc929842c2
  12. luke-jr force-pushed on May 2, 2019
  13. luke-jr renamed this:
    GUI: Move QRImageWidget to its own qrencoder file-pair
    GUI: Move QRImageWidget to its own file-pair
    on May 2, 2019
  14. laanwj commented at 6:25 PM on May 2, 2019: member

    utACK fc929842c20ac81869a33edce765e389a46e6c0c

  15. jonasschnelli commented at 6:31 PM on May 2, 2019: contributor

    Thanks @luke-jr. I wasn't aware of #15428. utACK fc929842c20ac81869a33edce765e389a46e6c0c

  16. laanwj merged this on May 6, 2019
  17. laanwj closed this on May 6, 2019
  18. laanwj referenced this in commit 9bbaac73bb on May 6, 2019
  19. deadalnix referenced this in commit f885ca69f5 on Oct 8, 2020
  20. deadalnix referenced this in commit ff9974a75e on Oct 8, 2020
  21. kittywhiskers referenced this in commit d56d62e618 on Nov 6, 2021
  22. kittywhiskers referenced this in commit 01c5201207 on Dec 5, 2021
  23. kittywhiskers referenced this in commit dc209f1130 on Dec 5, 2021
  24. kittywhiskers referenced this in commit 8102fca4f1 on Dec 12, 2021
  25. kittywhiskers referenced this in commit fc487f8407 on Dec 12, 2021
  26. kittywhiskers referenced this in commit 4486659768 on Dec 12, 2021
  27. PastaPastaPasta referenced this in commit a7f5379e19 on Dec 12, 2021
  28. DrahtBot locked this on Dec 16, 2021
Contributors
luke-jrlaanwjjonasschnelli
Labels
GUIRefactoringBuild system
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 15:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me