[WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code #15428

pull luke-jr wants to merge 6 commits into bitcoin:master from luke-jr:tor_gui_pairing changing 16 files +274 −55

luke-jr commented at 2:01 AM on February 17, 2019: member

This is intended to be merged only once the node can reliably provide a Tor hidden service for inbound connections.

It adds a "Pairing" tab to the GUI, which displays the onion address as copyable text, and a QR code (for scanning by mobile wallets).

TODO: Probably a BIP should be written for the bitcoin-p2p: URI scheme added here, and pairing behaviours.
Add signals for network local address added/removed bb77fe2999
GUI: Add getTorInfo to ClientModel d307e3c403
GUI: Refactor actual QR code rendering into new QRImageWidget::setQR 316e3c1b83
GUI: Add an extra stack to WalletFrame so non-wallet tabs are possible ac60b12b62
luke-jr force-pushed on Feb 17, 2019
fanquake added the label GUI on Feb 17, 2019
GUI: Add a new tab for pairing fd116c1e3e
GUI: Show onion address as text & QR code in Pairing tab 9a3d8526c9
luke-jr force-pushed on Feb 17, 2019

in src/qt/pairingpage.h:23 in 9a3d8526c9

  18 | +{
  19 | +    Q_OBJECT
  20 | +
  21 | +public:
  22 | +    explicit PairingPage(QWidget *parent = nullptr);
  23 | +    ~PairingPage() {};

practicalswift commented at 11:19 PM on February 25, 2019:

Nit: Accidental semicolon.

in src/qt/receiverequestdialog.cpp:42 in 9a3d8526c9

  38 | @@ -37,6 +39,64 @@ QRImageWidget::QRImageWidget(QWidget *parent):
  39 |      contextMenu->addAction(copyImageAction);
  40 |  }
  41 |  
  42 | +bool QRImageWidget::setQR(const QString& data, const QString& text)

practicalswift commented at 11:22 PM on February 25, 2019:

data here shadows a member variable?

luke-jr renamed this:
~~GUI: Add Pairing tab with Tor onion address as copyable text and QR code~~
[WIP] GUI: Add Pairing tab with Tor onion address as copyable text and QR code
on Feb 28, 2019
luke-jr commented at 9:06 AM on February 28, 2019: member

I think I need to rewrite this to work sanely with no-wallet builds. :/
luke-jr closed this on Feb 28, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

luke-jr

practicalswift

Labels

GUI