Give WalletModel::UnlockContext move semantics #16001

pull sipa wants to merge 1 commits into bitcoin:master from sipa:201905_moveunlockcontext changing 2 files +8 −5

sipa commented at 1:09 AM on May 10, 2019: member

WalletModel::UnlockContext seems to implement "move upon copy" semantics; with C++11 this can be done more safely using move semantics (making attempts to actually copy fail instead).

Not a big deal if this isn't worth review time.
Give WalletModel::UnlockContext move semantics 0b09a57aec
fanquake added the label GUI on May 10, 2019
fanquake added the label Wallet on May 10, 2019
DrahtBot commented at 3:30 AM on May 10, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15529 (Add Qt programs to msvc build by sipsorcery)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
in src/qt/walletmodel.cpp:488 in 0b09a57aec
```
 481 | @@ -482,7 +482,7 @@ WalletModel::UnlockContext::~UnlockContext()
 482 |      }
 483 |  }
 484 |  
 485 | -void WalletModel::UnlockContext::CopyFrom(const UnlockContext& rhs)
 486 | +void WalletModel::UnlockContext::CopyFrom(UnlockContext&& rhs)
 487 |  {
 488 |      // Transfer context; old object no longer relocks wallet
 489 |      *this = rhs;
```
promag commented at 1:48 PM on May 15, 2019:

Is this calling UnlockContext& operator=(UnlockContext&& rhs)?

sipa commented at 3:53 PM on May 15, 2019:

No, this calls the (private) default copy constructor.

Empact commented at 7:21 PM on May 15, 2019:

Because the rvalue arg becomes an lvalue once it's named (at the beginning of the function).
Empact commented at 7:23 PM on May 15, 2019: member

utACK https://github.com/bitcoin/bitcoin/pull/16001/commits/0b09a57aec4c56712711585a4314d73d4d9b6877
jonasschnelli commented at 10:16 AM on May 18, 2019: contributor

utACK 0b09a57aec4c56712711585a4314d73d4d9b6877
jb55 commented at 3:14 PM on May 18, 2019: member

utACK 0b09a57aec4c56712711585a4314d73d4d9b6877
meshcollider merged this on May 19, 2019
meshcollider closed this on May 19, 2019
meshcollider referenced this in commit 7263424458 on May 19, 2019
sidhujag referenced this in commit 1c5c552dfd on May 20, 2019
fanquake locked this on Jun 24, 2019

Contributors

Labels

Give WalletModel::UnlockContext move semantics #16001

Conflicts