tests: RPC bumpfee totalFee deprecation #16016

pull jonatack wants to merge 5 commits into bitcoin:master from jonatack:rpc_bumpfee_totalfee_deprecation_test changing 9 files +109 −59

jonatack commented at 9:03 AM on May 13, 2019: member

This is a follow-up to PR #15996 which deprecates the totalFee argument in RPC bumpfee.

If that PR is merged, several of the wallet_bumpfee tests will need to be updated to not use totalFee.

But first, we need a test for the deprecation itself. The intent of this PR is to add that coverage.
Move IsDeprecatedRPCEnabled to rpc/util.* to put into libbitcoin_common 0c39465500
deprecate totalFee argument in bumpfee RPC call 7ccf9dc2bd

Add RPC bumpfee totalFee deprecation test

Next steps: remove `totalFee` from the wallet_bumpfee functional tests.

14161cb811

Tidy up wallet_bumpfee.py code aaa6226e96
Tidy up wallet_bumpfee.py comments 96f3be13d9
fanquake added the label Tests on May 13, 2019
jonatack commented at 9:06 AM on May 13, 2019: member

(The tidy up commits are very much optional).
DrahtBot commented at 11:23 AM on May 13, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #15996 (rpc: Deprecate totalfee argument in bumpfee by instagibbs)
- #15911 (Use wallet RBF default for walletcreatefundedpsbt by Sjors)
- #15888 (QA: Add wallet_implicitsegwit to test the ability to transform keys between address types by luke-jr)
- #15427 (Add support for descriptors to utxoupdatepsbt by sipa)
- #15341 (rpc: Support specifying change address in bumpfee by promag)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fridokus commented at 7:59 AM on June 18, 2019: contributor

ACK 96f3be13d96becbd9586c6a4476329964cf625fd Ran functional tests locally and reviewed the code. No manual tests.
fanquake commented at 8:06 AM on June 18, 2019: member

@fridokus Thanks for the review. Given that this PR builds on top of #15996, you might also be interested in testing and ACKing there, especially since the commits from 15996 that are part of this PR are no longer up to date.
fanquake renamed this:
~~[tests] RPC bumpfee totalFee deprecation~~
tests: RPC bumpfee totalFee deprecation
on Jun 18, 2019
fridokus commented at 8:18 AM on June 18, 2019: contributor

Aha. Will do :)
jnewbery commented at 9:11 PM on June 19, 2019: member

@jonatack - the commit that adds the test has been added to #15996. Are you happy to close this PR now? (you can either open a PR for the tidy-up commits or just drop them)
jonatack commented at 9:26 PM on June 19, 2019: member

@jnewbery Sure. My intent was to update the tests to not use totalFee but can do it in a separate PR and not divert further review time.
jonatack closed this on Jun 19, 2019
jonatack commented at 9:57 PM on June 19, 2019: member

(Thank you for the review, @fridokus.)
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#15996 rpc: Deprecate totalfee argument in `bumpfee`

tests: RPC bumpfee totalFee deprecation #16016

Conflicts