rpc: Drop -rpcuser and -rpcpassword from server #16017

pull promag wants to merge 1 commits into bitcoin:master from promag:2019-05-remove-rpcpassword changing 4 files +10 −15

promag commented at 2:14 PM on May 13, 2019: member

Options -rpcuser and -rpcpassword are deprecated, -rpcauth should be used instead.
DrahtBot commented at 2:36 PM on May 13, 2019: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #12040 (fix: add support for CORS headers and pre-flight request by lionello)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke commented at 2:48 PM on May 13, 2019: member

I think a lot of "tutorials" still mention this setting, so maybe removing it is a bit premature. Needs release notes either way.
rpc: Drop -rpcuser and -rpcpassword from server fe31964831
promag force-pushed on May 13, 2019
promag commented at 2:55 PM on May 13, 2019: member

I think a lot of "tutorials" still mention this setting, so maybe removing it is a bit premature.

The same can be said for all deprecated options.

Release note added.

BTW why no travis?
DrahtBot added the label Docs on May 13, 2019
DrahtBot added the label RPC/REST/ZMQ on May 13, 2019
DrahtBot added the label Utils/log/libs on May 13, 2019
kristapsk commented at 3:03 PM on May 13, 2019: contributor

There are third party tutorials in the wild that mentions these settings, also it breaks things for already configured setups. Maybe it's better idea to first deprecate with a warning and postpone removal to some later release?
kristapsk commented at 3:09 PM on May 13, 2019: contributor

See also #14363.
kristapsk commented at 3:15 PM on May 13, 2019: contributor

Ahh, didn't notice there was already deprecation warning. But it only goes to debug.log of bitcoind, which most of the users may not look at unless there are problems. They should at least be added to bitcoin-cli first too IMO.
promag commented at 3:16 PM on May 13, 2019: member

@kristapsk the warning is already there: https://github.com/bitcoin/bitcoin/blob/e79bbb73e08e3f191e97d3b67a2fbb510c5545ff/src/httprpc.cpp#L227

This doesn't change RPC behavior, it just changes how you configure the server - I mean, it doesn't force you to refactor your client code.
gmaxwell commented at 4:55 PM on May 13, 2019: contributor

It might be better to deactivate and require reenabling it to keep using it.
promag commented at 4:58 PM on May 13, 2019: member

@gmaxwell it's already "deactivated" unless you set the options?
gmaxwell commented at 7:21 PM on May 13, 2019: contributor

It is, but many people set the options 5+ years ago. There has been no /active/ notification to those users. A nag in the debug log isn't nothing, true, but it's not much. :) Is there any pressing reason to remove this? AFAIK removing it just saves a couple lines of code.
promag commented at 7:25 PM on May 13, 2019: member

No pressing reason. Let's remove the warning then? :trollface:
promag closed this on May 13, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Docs RPC/REST/ZMQ Utils/log/libs

rpc: Drop -rpcuser and -rpcpassword from server #16017

Conflicts