doc: analyzepsbt description in doc/psbt.md #16047

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:improve-analyzepsbt-doc changing 1 files +4 −3

jonatack commented at 3:32 PM on May 19, 2019: member
- fix: replace "RPC" with "PSBT"
- output includes the current status of the analyzed psbt's inputs
- apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled
- add "final" to the estimated weight and feerate

doc: fix/improve analyzepsbt in doc/psbt.md

- fix: replace "RPC" with "PSBT"

- output includes the current status of the analyzed psbt's inputs

- apply "if possible" to the fee as well as to the estimated weight and feerate, since the fee is only shown if all utxo slots in the psbt have been filled

- add "final" to the estimated weight and feerate

d5dc66e280

fanquake added the label Docs on May 19, 2019
laanwj commented at 2:39 PM on May 20, 2019: member

Eh yes much better ACK d5dc66e28046a146b6fdf10ed119dfe4e96af995

in doc/psbt.md:85 in d5dc66e280

  81 | @@ -82,9 +82,10 @@ hardware implementations will typically implement multiple roles simultaneously.
  82 |    transactions.
  83 |  - **`decodepsbt`** is a diagnostic utility RPC which will show all information in
  84 |    a PSBT in human-readable form, as well as compute its eventual fee if known.
  85 | -- **`analyzepsbt`** is a utility RPC that examines an RPC and reports the
  86 | -  next steps in the workflow if known, computes the fee of the resulting
  87 | -  transaction, and estimates the weight and feerate if possible.
  88 | +- **`analyzepsbt`** is a utility RPC that examines a PSBT and reports the

laanwj commented at 2:41 PM on May 20, 2019:

shouldn't it be "an utility RPC" ?

sipa commented at 2:48 PM on May 20, 2019:

Seems not: https://www.englishforums.com/English/AUtilityVsAnUtility/hrmlw/post.htm

laanwj commented at 5:34 PM on May 23, 2019:

ok i'm only more confused after reading that :laughing: in any case, it's not a blocker for me

jonatack commented at 5:53 PM on May 23, 2019:

I thought it might be a British English vs American English thing, but turns out the Oxford site here https://en.oxforddictionaries.com/definition/utility says:

British & World English: utility 

3 Computing
A utility program.

fanquake commented at 10:17 PM on May 25, 2019: member

utACK d5dc66e
laanwj merged this on May 29, 2019
laanwj closed this on May 29, 2019
laanwj referenced this in commit 411e5f1547 on May 29, 2019
jonatack deleted the branch on May 29, 2019
sidhujag referenced this in commit 6052883423 on May 30, 2019
jasonbcox referenced this in commit 7c956ab21d on Oct 5, 2020
Munkybooty referenced this in commit caeb9f704e on Oct 17, 2021
Munkybooty referenced this in commit 5263d8b954 on Oct 25, 2021
MarcoFalke locked this on Dec 16, 2021

Contributors

Labels