Catch by reference not value in wallettool #16095

pull kristapsk wants to merge 1 commits into bitcoin:master from kristapsk:catch-by-ref-wallettool changing 1 files +1 −1

kristapsk commented at 3:40 PM on May 26, 2019: contributor

Fixes this warning with GCC8/GCC9:

wallet/wallettool.cpp: In function ‘std::shared_ptr<CWallet> WalletTool::LoadWallet(const string&, const boost::filesystem::path&)’:
wallet/wallettool.cpp:62:25: warning: catching polymorphic type ‘const class std::runtime_error’ by value [-Wcatch-value=]
     } catch (const std::runtime_error) {
                         ^~~~~~~~~~~~~

Related to #15822.

Exceptions should be caught by reference, not by value. ae7faf20d5
fanquake added the label Wallet on May 26, 2019
practicalswift commented at 4:43 PM on May 26, 2019: contributor

utACK ae7faf20d5fb3e2415ccadc37100dfc44aa0cd94
MarcoFalke merged this on May 27, 2019
MarcoFalke closed this on May 27, 2019
MarcoFalke referenced this in commit 76e2cded47 on May 27, 2019
kristapsk deleted the branch on May 27, 2019
MarcoFalke referenced this in commit e29aa6e72e on Jun 18, 2019
HashUnlimited referenced this in commit 5f40572511 on Aug 23, 2019
Bushstar referenced this in commit a33422466c on Aug 24, 2019
DrahtBot locked this on Dec 16, 2021

Contributors

kristapsk

practicalswift

Labels

Wallet

Linked (view graph)

#15822 gui: Building with gcc 9 prints a trillion warnings (-Wdeprecated-copy)