contrib: add curl as a required program in gitian-build.py #16114

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:gitian-build-missing-curl changing 1 files +1 −1

fanquake commented at 4:54 PM on May 28, 2019: member

Fixes: #16109

Adds curl to the list of base programs required by the gitian-build.py script.
contrib: add curl as a required program in gitian-build.py 97dce72261
fanquake added the label Scripts and tools on May 28, 2019
in contrib/gitian-build.py:10 in 97dce72261
```
   6 | @@ -7,7 +7,7 @@
   7 |  
   8 |  def setup():
   9 |      global args, workdir
  10 | -    programs = ['ruby', 'git', 'make', 'wget']
  11 | +    programs = ['ruby', 'git', 'make', 'wget', 'curl']
```
hebasto commented at 5:12 PM on May 28, 2019:

May I suggest to add the lsb-release package which is used here: https://github.com/bitcoin/bitcoin/blob/76e2cded477bc483ec610212bdadf21fe35292d4/contrib/gitian-build.py#L177 Tested on Debian Buster RC1 NETINST 201900411.

MarcoFalke commented at 5:25 PM on May 28, 2019:

How is that going to help? lsb_release is called before setup().

hebasto commented at 5:56 PM on May 28, 2019:

lsb_release is called before setup().

You are right. The lsb-release package is just a prerequisite like the python3.
hebasto commented at 5:13 PM on May 28, 2019: member

tACK 97dce7226194d5d8a06787afef7df08cebb66bd6 on Debian Buster RC1.
MarcoFalke referenced this in commit e78c33131b on May 28, 2019
MarcoFalke merged this on May 28, 2019
MarcoFalke closed this on May 28, 2019
fanquake deleted the branch on May 28, 2019
UdjinM6 referenced this in commit 3eb5542cff on Sep 2, 2021
UdjinM6 referenced this in commit 7a9b5cb3eb on Sep 2, 2021
DrahtBot locked this on Dec 16, 2021

Contributors

Labels

Linked (view graph)

#16109 gitian-build.py --setup should install curl